Repository navigation
feat: [SDK-5533] add log view spec and JS event assertions - #56
Merged
Merged
Conversation
Specify a sticky log view for all demos and assert JS listener events through it. checkNotification now expects one foregroundWillDisplay and one click entry per notification, and Android taps the notification so the click fires on both platforms. Demos without a log view skip the assertions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nan-li
approved these changes
Oct 13, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Specify a sticky log view for every demo app and use it in the Appium suite to assert JS listener events. Until now the suite only checked native-visible effects (a notification appearing, a launch URL opening), so wrapper bugs in the JS event path went unnoticed.
Details
Demo spec
demo/build.md: exact log message formats for SDK listeners (Prompt 1.5), new Log View prompt (2.0), log entries listed as not persisted (Phase 5), Log View test idslog_view,log_entry_{index},log_clear_button,log_toggle_button(6.2)demo/styles.md: Log View stylingAppium
tests/helpers/app.ts:hasLogView,getLogMessages,countLogMessages,expectOneNewLogcheckNotification(02_push) now expects exactly one newforegroundWillDisplayand one newclicklog entry per notificationwaitForNotificationtaps the notification instead of pressing back, so the click fires on both platforms (iOS already tapped the banner)Effect on existing runs
Assertions skip when the demo has no
log_view, so demos without one keep passing during rollout (SDK-5523). The Capacitor demo adds it in OneSignal/OneSignal-Capacitor-SDK#74.Testing
run-local --platform=android --sdk=capacitor --spec=02with the Capacitor demo from #74: 3/3 passing, log assertions executed (not skipped).🤖 Generated with Claude Code