Add Number of software identification fields as byte 1 when sending PGN 65242 Software Identification - #704
Open
sam-brodie wants to merge 1 commit into
Open
Conversation
…GN 65242 Software Identification. See https://www.isobus.net/isobus/pGNAndSPN/16988?type=PGN
Member
|
Likewise with this PR, I'm happy to approve it if you fix the associated unit test. If you have trouble with that or need one of us to do it, just let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Number of software identification fields as byte 1 when sending PGN 65242 Software Identification. See https://www.isobus.net/isobus/pGNAndSPN/16988?type=PGN
Describe your changes
Byte 1 of the Software ID message should be the Number of Software Identification Fields. This change adds that
How has this been tested?
Verified with the AEF Conformance Test Tool that it fails the relevant test cases without this fix.