Update the length of the heartbeat message to be 8 and fill the remaining bytes with 0xFF - #705
Open
sam-brodie wants to merge 1 commit into
Open
Update the length of the heartbeat message to be 8 and fill the remaining bytes with 0xFF#705sam-brodie wants to merge 1 commit into
sam-brodie wants to merge 1 commit into
Conversation
…ning bytes with 0xFF
Member
|
This appears to be a very recent change to the definition of the heartbeat message - and for some reason, they didn't update the PG modify date in the online database. Very odd. Anyways, thanks for this contribution. I will approve it if you update the tests, which are currently expecting a length of 1, so that just needs to be changed to 8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the length of the heartbeat message to be 8 and fill the remaining bytes with 0xFF. The Heartbeat message has a length of 8 https://www.isobus.net/isobus/pGNAndSPN/3299?type=PGN
Describe your changes
Pad the heartbeat message with 0xFF to a length of 8.
How has this been tested?
Using Vector CANoe to request the heartbeat, CANoe will flag that the lengths is incorrect.