Repository navigation
Repartition data after loading IO class configuration - #881
Merged
Merged
Conversation
Deixx
force-pushed
the
ioclass-repart
branch
4 times, most recently
from
April 17, 2025 11:37
739b071 to
76c3d31
Compare
mmichal10
reviewed
Apr 18, 2025
Deixx
marked this pull request as draft
April 23, 2025 05:46
robertbaldyga
force-pushed
the
ioclass-repart
branch
from
October 16, 2026 17:17
86c6bbc to
45ce1eb
Compare
robertbaldyga
marked this pull request as ready for review
October 16, 2026 17:18
Add ocf_user_part_move_all() moving all cache lines of a user partition to another one. It's meant to be called under exclusive metadata access, which keeps out every concurrent metadata update, so cache line locks are not needed and lines held by in-flight requests are moved as well. Moved lines are inserted at the cold end of the destination LRU lists (new ocf_lru_repart_cold()), preserving their relative order, so they neither displace hot data of the destination partition nor trigger its hot/cold rebalancing. The per-line part (cleaning policy and per-core counters update) is factored out of ocf_user_part_move() and shared by both paths. Signed-off-by: Daniel Madej <daniel.madej@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Add a per IO class `repart` flag to struct ocf_mngt_io_class_config. When set, ocf_mngt_cache_io_classes_configure() moves cache lines of that IO class to the unclassified IO class, both when the class is updated and when it's removed. The lines get reclassified on the next access. Only the user knows whether a modified classification rule changes the meaning of the IO class, so the decision is left to them per IO class. Repartitioning is done after the whole configuration is applied, as it can't be rolled back. Update the pyocf mirror of the structure accordingly. Signed-off-by: Daniel Madej <daniel.madej@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
robertbaldyga
force-pushed
the
ioclass-repart
branch
from
October 16, 2026 17:55
45ce1eb to
2a6f082
Compare
Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
robertbaldyga
force-pushed
the
ioclass-repart
branch
from
October 16, 2026 22:42
2a6f082 to
f6e78a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.