Repository navigation
Policy params tests and fixes - #985
Merged
robertbaldyga merged 4 commits intoOct 15, 2026
Merged
Conversation
The ranges are defined inclusively, so using regular range() causes off-by-one bug. Introduce range_inclusive() to express inclusive ranges explicitly and avoid this class of bugs. Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
This fixes standby, which did not call setup for the policies at all, and detach/attach path, which did not preserve policies parameters. It also simplifies setup handling, as now all the policies are set to default on cache creation, so on attach/standby_attach everything is already initialized, and on the load path, the params are just overwritten with metadata from the disk. Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Check if cleaning/promotion/cleaning policy params are preserved after cache is detached and attached. Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
robertbaldyga
force-pushed
the
policy-params-fixes
branch
from
October 15, 2026 19:34
6af21d5 to
5c1021f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.