Sync Unit 3 lessons 3.4 and 3.6 with code runner updates - #1559
Closed
dhyantsoni wants to merge 1 commit into
Closed
dhyantsoni wants to merge 1 commit into
dhyantsoni wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Add a background to the new runner callout styling to preserve contrast.
Review effort: Lite
Findings: None
What changed in this PR
Updates Unit 3 Java lessons 3.4 and 3.6 to the current code-runner format and refreshes runner styling and integration.
Changes:
- Converts lesson exercises and hacks to
CODE_RUNNERcells. - Removes outdated answer keys and interactive content.
- Renames and restyles runner challenge boxes.
| File | Summary |
|---|---|
assets/js/runner-io.js |
Reads the renamed challenge-box class. |
_sass/open-coding/mixins/_panel.scss |
Adds callout styling; runner background styling requires adjustment. |
_sass/open-coding/forms/game-runner.scss |
Updates hidden challenge-box selectors. |
_sass/open-coding/forms/_runner-base.scss |
Applies runner challenge styling. |
_projects/lessons/java/notebooks/2025-09-21-3.6.ipynb |
Converts reference exercises to code runners. |
_projects/lessons/java/notebooks/2025-09-21-3.4.ipynb |
Updates constructor exercises and runner cells. |
_includes/runners/fragments/challenge-box.html |
Renames the challenge-box class. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
… branch Brings over teammate work from CSA-Admin-OCS lessons that is not yet upstream: 3.4 constructors (answer keys and LxD removed, hacks submitted in-file), 3.6 rework to CODE_RUNNER cells, and the shared runner styling. Upstream's reorganized frontmatter cells are kept as-is. Co-authored-by: Shayanb1 <shayanb1245@gmail.com> Co-authored-by: Darshan528 <wkeynoping@gmail.com>
dhyantsoni
force-pushed
the
lessons-upstream-pr
branch
from
September 21, 2026 11:55
213fda1 to
8aaffd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the Unit 3 lessons already merged in ac6866a. This brings over the remaining work from the
CSA-Admin-OCS:lessonsbranch that is not yet onmain:CODE_RUNNERformat and shortened_runner-base.scss,game-runner.scss,_panel.scssmixin,challenge-box.html,runner-io.jsLessons 3.1, 3.2, 3.3, 3.5, 3.8 and the JWT lesson are already identical to
mainapart from frontmatter, so they are not touched here.Notes
mainrather than from thelessonsbranch directly (that branch conflicts withmainin 155 places, which is why Add 3.4 Constructors lesson #1508 was 626 files). This PR is 7 files.lessonsbranch) and the mentor-role dashboard change, which is a separate feature.Lesson authors: Shayanb1, Darshan528