Skip to content

Fix deprecation warning that was being picked up by pytest - #97

Merged
dylanjmcconnell merged 1 commit into
Open-ISP:mainfrom
bje-:test-warnings
Sep 16, 2026
Merged

dylanjmcconnell merged 1 commit into
Open-ISP:mainfrom
bje-:test-warnings

Conversation

@bje-

@bje- bje- commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

This output was caught by pytest and is easily corrected by wrapping the iterator in list().

==== summary ====
.venv/lib/python3.12/site-packages/_pytest/python.py:124
  /home/bje/source/isp-workbook-parser/.venv/lib/python3.12/site-packages/_pytest/python.py:124: PytestRemovedIn10Warning: Passing a non-Collection iterable to parametrize is deprecated.
  Test: tests/test_packaged_table_configs.py::test_packaged_table_configs_for_each_version, argvalues type: generator
  Please convert to a list or tuple.
  See https://docs.pytest.org/en/stable/deprecations.html#parametrize-iterators
    metafunc.parametrize(*marker.args, **marker.kwargs, _param_mark=marker)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

==== summary ====
.venv/lib/python3.12/site-packages/_pytest/python.py:124
  /home/bje/source/isp-workbook-parser/.venv/lib/python3.12/site-packages/_pytest/python.py:124: PytestRemovedIn10Warning: Passing a non-Collection iterable to parametrize is deprecated.
  Test: tests/test_packaged_table_configs.py::test_packaged_table_configs_for_each_version, argvalues type: generator
  Please convert to a list or tuple.
  See https://docs.pytest.org/en/stable/deprecations.html#parametrize-iterators
    metafunc.parametrize(*marker.args, **marker.kwargs, _param_mark=marker)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
@codecov

codecov Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dylanjmcconnell
dylanjmcconnell merged commit 3b158fd into Open-ISP:main Sep 16, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants