Skip to content

fix(remote-input): ignore stale audio preparation after stop or cancel - #1110

Closed
EthanYoQ wants to merge 1 commit into
Open-Less:betafrom
EthanYoQ:fix/remote-input-audio-generation
Closed

EthanYoQ wants to merge 1 commit into
Open-Less:betafrom
EthanYoQ:fix/remote-input-audio-generation

Conversation

@EthanYoQ

Copy link
Copy Markdown
Contributor

Summary

Prevent stopped/cancelled microphone setup from corrupting a later remote-input recording. Advance audioGen on capture teardown and guard late resume, microphone, worklet and timeout callbacks. Preserve microphone reuse. Only app.js and one regression test change; no dependencies, protocol, settings or CI changes.

Verification

At commit 9479279:

  • Original source: 8 failing / 3 passing tests.
  • Patched source: 11/11 passing tests; both node --check and git diff --check pass.
  • Tests read the full application source but execute production function bodies in a Node VM with mocked browser effects. Not a full-page or device test.
  • Run: node --test openless-all/app/scripts/remote-input-audio-generation.test.mjs

Pending

Full npm ci / npm test, repository formatting checks, upstream CI and real phone/desktop validation were not run. Please keep this PR in Draft until the remaining checks are completed.

AI-assisted change. Revert the single two-file commit to roll back; no user-data migration.

Invalidate in-flight audio setup on every capture teardown and guard
resume, microphone, worklet and timeout continuations by generation.
Preserve normal microphone reuse and add deterministic regression tests.
@appergb

appergb commented Sep 26, 2026

Copy link
Copy Markdown
Collaborator

过期音频准备回调隔离已随 2.0.0-Beta.3 集成进入 beta 分支(提交 51f6f4c),代码已实际合入,此处补关并随 v2.0.0-Beta.3-tauri 发布。感谢贡献!

@appergb appergb closed this Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants