Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After trying local ASR, a legacy active provider such as
local-qwen3-mlxcan survive a switch back to cloud channels. Settings marks the first enabled cloud channel as current, while request resolution can interpret the stale value as a provider type and bypass channel order and enabled state.This makes the first enabled ASR/LLM channel authoritative for credential metadata, status and new requests. Desktop credential loading reconciles cached active IDs on every load, including already migrated/restored vaults; existing gated writes persist the correction. Channel mutations repair stale caches, and explicit activation rejects unknown provider IDs when channels exist. The local model page reads backend credential status and subscribes to changes instead of using the legacy preference for its active badges.
A nonempty list with all channels disabled has no active provider. Legacy preference fallback remains supported for stores without channels. Omni retains its independent selection, ongoing recordings retain their initial channel/protocol/model, and switching away from local ASR keeps downloaded models and credentials. Restart reconciliation does not make network validation requests or silently fail over to another provider.
Validation:
npm testsuite passed (TypeScript/Vite build plus all frontend/contract tests). The React state setter uses a distinct name from the backend channel activation API, retaining the activation-boundary contract.Selection policy is documented in
docs/provider-channel-selection.md.