Skip to content

Remove Prebid code scanner workflow (missing GitHub App credentials) - #104

Merged
khang-vu-ttd merged 1 commit into
masterfrom
remove-prebid-code-scanner
Aug 13, 2026
Merged

khang-vu-ttd merged 1 commit into
masterfrom
remove-prebid-code-scanner

Conversation

@khang-vu-ttd

Copy link
Copy Markdown
Contributor

Summary

  • `.github/workflows/prebid-code-scanner.yml` was added by the 11.18.0→11.19.0 sync (upstream-sync: sync Prebid.js 11.18.0 → 11.19.0 #102) and fails immediately on every run with an OpenSSL PEM-decode error, because it needs a Prebid.org-specific GitHub App (`CODE_SCANNER_PEM`/`CODE_SCANNER_APPID`/`CODE_SCANNER_INSTALLATION`) that was never configured for this fork.
  • The action's own description scopes it to scanning code "submitted by Prebid member companies" for suspect patterns — an external-community-contributor threat model that doesn't really apply to this fork (OpenAdsJs only receives upstream sync commits and internal team PRs).
  • Removing the workflow rather than standing up a dedicated GitHub App for a check that doesn't fit this fork's use case.

Test plan

  • Confirm no other workflow or process depends on this file
  • Merge and confirm the "Prebid code scanner" check no longer appears on new/existing PRs

This workflow (added via the 11.18.0->11.19.0 sync, PR #102) requires a
Prebid.org-specific GitHub App (CODE_SCANNER_PEM/CODE_SCANNER_APPID/
CODE_SCANNER_INSTALLATION) that was never configured for this fork, causing
every run to fail immediately with an OpenSSL decode error on the empty PEM
secret.

The action's own description scopes it to scanning code 'submitted by Prebid
member companies' for suspect patterns from external community
contributors -- a threat model that doesn't really apply to this fork, which
only receives upstream sync commits and internal team PRs. Removing rather
than trying to stand up a dedicated GitHub App for it.
@khang-vu-ttd
khang-vu-ttd merged commit 2141651 into master Aug 13, 2026
111 of 113 checks passed
@khang-vu-ttd
khang-vu-ttd deleted the remove-prebid-code-scanner branch August 13, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant