feat: HuggingFace Hub auto-download and sample rate defaults - #376
Open
bluecrystaladmin wants to merge 2 commits into
Open
feat: HuggingFace Hub auto-download and sample rate defaults#376bluecrystaladmin wants to merge 2 commits into
bluecrystaladmin wants to merge 2 commits into
Conversation
Add snapshot_download() resolution for pretrained_path so users can specify a HF model ID (e.g., 'openbmb/VoxCPM2') directly. Changes: - Default pretrained_path falls back to Hub ID when no local dirs exist - _resolve_pretrained_path() helper downloads from Hub on first use - Training and inference resolve path before reading config.json - Default sample_rate corrected to 16000 (matches AudioVAE expectation) Enables zero-setup usage: the WebUI auto-downloads the model on first run.
Contributor
|
Thanks for the fix! One suggestion: |
Replace _resolve_pretrained_path() (fragile '/' heuristic) with a shared resolve_model_path() helper in core.py that uses os.path.isdir() — the same robust check from VoxCPM.from_pretrained(). - New resolve_model_path() in core.py, exported from voxcpm package - from_pretrained() delegates to resolve_model_path() - Training WebUI imports and uses the same shared helper - Eliminates duplicate resolution logic and '/' misclassification of relative local paths as Hub IDs Per upstream review on PR OpenBMB#376.
Contributor
|
Nice cleanup, thanks! One small leftover: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #375
Add snapshot_download() resolution for pretrained_path so users can specify a HF model ID (e.g., 'openbmb/VoxCPM2') directly.
Changes:
Enables zero-setup usage: the WebUI auto-downloads the model on first run.