Conversation
lohedges
had a problem deploying
to
sire-build
September 21, 2026 10:52 — with
GitHub Actions
Failure
lohedges
had a problem deploying
to
sire-build
September 21, 2026 10:52 — with
GitHub Actions
Failure
lohedges
had a problem deploying
to
sire-build
September 21, 2026 10:52 — with
GitHub Actions
Failure
Contributor
Author
|
Failures are GitHub actions network issues causing IO errors. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #483.
Dynamics.run()stepped the integrator in fixed blocks of 50 steps, and after each block_exit_dynamics_block()callsgetState(getEnergy=True), which is a full force evaluation and a GPU sync. The blocks only exist to update the progress bar; crash recovery is unaffected by them, since it restores the snapshot taken beforerun()was called. Each block now runs to the next frame or energy save, or the end of the run, and the 50 step cap is applied only when the progress bar is visible.ProgressBargains anis_silent()query for this, tracked in the Python wrapper alongsideset_silent(). Because a block can now be long, its length is fixed from both the next frame and the next energy save before either flag is set, so that one save shortening the block cannot move the other; a side effect is that saves now land on the requested step rather than at the end of a 50 step block. The existing dynamics tests cover the frame and energy scheduling and pass with the progress bar both shown and silenced.On a 46646 atom protein-ligand system at 4 fs on an RTX 5070 Ti, with the progress bar silenced as somd2 does,
Dynamics.run()with nothing saved went from 0.380 to 0.360 ms/step against 0.356 ms/step for the raw integrator, and with an 11 window energy scan every 2 ps from 0.381 to 0.367 ms/step.develinto this branch before issuing this pull request (e.g. by runninggit pull origin devel): [y]