Skip to content

Changed OpenCHAMI to openchami in the module name - #110

Open
shunr-hpe wants to merge 2 commits into
mainfrom
fix-module-name
Open

Changed OpenCHAMI to openchami in the module name#110
shunr-hpe wants to merge 2 commits into
mainfrom
fix-module-name

Conversation

@shunr-hpe

Copy link
Copy Markdown
Collaborator

Pull Request Template

Thank you for your contribution! Please ensure the following before submitting:

Checklist

  • My code follows the style guidelines of this project
  • I have added/updated comments where needed
  • I have added tests that prove my fix is effective or my feature works
  • I have run make test (or equivalent) locally and all tests pass
  • I have updated the relevant documentation (CLI examples, man pages, README, other docs, etc.)
  • DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
  • REUSE Compliance:
    • Each new/modified source file has SPDX copyright and license headers
    • Any non-commentable files include a <filename>.license sidecar
    • All referenced licenses are present in the LICENSES/ directory

Description

Please include a summary of the change and which issue is fixed.
Also include relevant motivation and context.

Partial fix for #(OpenCHAMI/roadmap#135)

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Dependency update

For more info, see Contributing Guidelines.

Signed-off-by: Shane Unruh <shane.unruh@hpe.com>
@shunr-hpe
shunr-hpe requested a review from synackd August 3, 2026 16:25
Comment thread go.mod Outdated
@@ -1,4 +1,4 @@
module github.com/OpenCHAMI/smd/v2
module github.com/openchami/smd2/v2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we changing the module name to have smd2?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Catch! I did not mean to do that.
I'll fix it so that it is github.com/openchami/smd/v2

Signed-off-by: Shane Unruh <shane.unruh@hpe.com>

@synackd synackd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll also want to change the paths here:

smd/Dockerfile.CSM

Lines 42 to 55 in a07d4a2

COPY cmd $GOPATH/src/github.com/OpenCHAMI/smd/cmd
COPY internal $GOPATH/src/github.com/OpenCHAMI/smd/internal
COPY pkg $GOPATH/src/github.com/OpenCHAMI/smd/pkg
COPY vendor $GOPATH/src/github.com/OpenCHAMI/smd/vendor
### Build Stage ###
FROM base AS builder
# Base image contains everything needed for Go building, just build.
RUN set -ex \
&& go build -v -tags musl -i github.com/OpenCHAMI/smd/cmd/smd \
&& go build -v -tags musl -i github.com/OpenCHAMI/smd/cmd/smd-loader \
&& go build -v -tags musl -i github.com/OpenCHAMI/smd/cmd/smd-init

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants