power-policy-service: Introduce DisconnectReason enum - #940
Open
RobertZ2011 wants to merge 1 commit into
Open
Conversation
RobertZ2011
force-pushed
the
set-renegotiate-same-psu
branch
from
August 7, 2026 16:09
3a65d39 to
88e9c85
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts power-policy behavior to distinguish a consumer “renegotiation” from a true PSU switch when the best consumer remains the same device but its requested capability changes. In support of more accurate Type-C/PD status reporting, it also tightens parsing of the first received source PDO (expecting a fixed PDO) and propagates additional source-side flags into PortStatus, including EPR capability. Finally, it updates the PortStatus::epr field documentation to reflect the intended meaning.
Changes:
- Treat “same device” consumer transitions as renegotiations (flagged via
ConsumerDisconnect::renegotiation) instead of switching. - Extract the first RX source PDO as
Fixedand use its fields to populatedual_power,unconstrained_power, andeprin Type-C port status. - Update the
PortStatus::eprdoc comment to describe EPR capability.
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| type-c-service/src/driver/tps6699x.rs | Reads RX source caps and uses the first fixed PDO to populate additional PortStatus power flags, including EPR capability. |
| power-policy-service/src/consumer.rs | Differentiates renegotiation vs switching when the best consumer remains the same device. |
| embedded-service/src/type_c/controller.rs | Updates the PortStatus::epr field documentation to match its intended meaning. |
RobertZ2011
force-pushed
the
set-renegotiate-same-psu
branch
from
August 7, 2026 17:42
88e9c85 to
efb5653
Compare
Combine existing disconnect reasons into this enum and distinguish between renegotiation types. Also rename `ConsumerDisconnect` to `Disconnect` since this type is already used for provider disconnect flags as well.
RobertZ2011
force-pushed
the
set-renegotiate-same-psu
branch
from
August 7, 2026 17:45
efb5653 to
c915506
Compare
RobertZ2011
changed the title
DisconnectReason enum
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
Suppressed comments (1)
embedded-service/src/power/policy/flags.rs:167
- Doc comment for
InvalidDisconnectReasonrefers toPsuType, but this error is forDisconnectReasonconversion failures. This looks like a copy/paste mistake and can mislead readers.
/// Conversion error for [`PsuType`]
benonivainqueur
approved these changes
Aug 7, 2026
RobertZ2011
marked this pull request as ready for review
August 7, 2026 20:38
RobertZ2011
requested review from
asasine,
chchongmsft,
colindonahue,
gjpmsft,
jerrysxie,
kurtjd,
seanbrns,
thdesil,
tullom and
williampMSFT
August 7, 2026 20:38
kurtjd
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combine existing disconnect reasons into this enum and distinguishbetween renegotiation types. Also rename
ConsumerDisconnecttoDisconnectsince this type is already used for provider disconnect flags as well.