Skip to content

[feature/supv] Add the support of programming MSEG during each core initialization - #1701

Merged
kuqin12 merged 7 commits into
OpenDevicePartnership:feature/supvfrom
kuqin12:supv_sea
Aug 12, 2026
Merged

[feature/supv] Add the support of programming MSEG during each core initialization#1701
kuqin12 merged 7 commits into
OpenDevicePartnership:feature/supvfrom
kuqin12:supv_sea

Conversation

@kuqin12

@kuqin12 kuqin12 commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Description

This change adds a parser for the MSEG_SMRAM_HOB so that the SMM can program the MSEG MSR during the first MMI entry.

This change also exposed the efi_main to make it discoverable in the PDB file.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

This was tested on a customized QEMU Q35 platform and booted to UEFI shell.

Integration Instructions

For platforms elect to support SEA, integrate the MSEG prepare PEI into the platform and link the STM based CPU feature library into the MM initializer.

@github-actions github-actions Bot added the impact:security Has a security impact label Aug 8, 2026
@patina-automation

patina-automation Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

✅ QEMU Validation Passed

All QEMU validation jobs completed successfully.

Note: Q35 is only built on Windows hosts (QEMU boot is disabled due to a QEMU vfat issue).

Workflow run: https://github.com/OpenDevicePartnership/patina/actions/runs/31574968645

Boot Time to EFI Shell

Platform Elapsed
ArmVirt (Linux Host) 21.6s
Q35 (Linux Host) 29.5s

Dependencies

Repository Ref
patina 3c1c636
patina-dxe-core-qemu d8e9540
patina-fw-patcher d06ba7e
patina-qemu firmware v4.0.5
patina-qemu build script 716e869

This comment was automatically generated by the Patina QEMU PR Validation Post workflow.

@makubacki
makubacki self-requested a review August 8, 2026 00:34
@makubacki

Copy link
Copy Markdown
Collaborator

I don't have time to review now, but am interested to do so next week if it can wait.

@codecov

codecov Bot commented Aug 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 40.47619% with 25 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
patina_mm_supervisor/src/init.rs 50.00% 17 Missing ⚠️
patina_mm_supervisor/src/state.rs 0.00% 7 Missing ⚠️
patina_mm_supervisor/src/lib.rs 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Comment thread patina_mm_supervisor/src/init.rs Outdated
Comment thread patina_mm_supervisor/src/init.rs Outdated
Comment thread patina_mm_supervisor/src/init.rs Outdated
Comment thread patina_mm_supervisor/src/init.rs
@makubacki makubacki changed the title Add the support of programming MSEG during each core initialization [feature/supv] Add the support of programming MSEG during each core initialization Aug 11, 2026
@kuqin12
kuqin12 merged commit 62d6d84 into OpenDevicePartnership:feature/supv Aug 12, 2026
10 of 11 checks passed
@kuqin12
kuqin12 deleted the supv_sea branch August 12, 2026 17:05
kuqin12 added a commit that referenced this pull request Aug 13, 2026
…nitialization (#1701)

## Description

This change adds a parser for the `MSEG_SMRAM_HOB` so that the SMM can
program the MSEG MSR during the first MMI entry.

This change also exposed the `efi_main` to make it discoverable in the
PDB file.

- [x] Impacts functionality?
- [x] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?

## How This Was Tested

This was tested on a customized QEMU Q35 platform and booted to UEFI
shell.

## Integration Instructions

For platforms elect to support SEA, integrate the MSEG prepare PEI into
the platform and link the STM based CPU feature library into the MM
initializer.
kuqin12 added a commit that referenced this pull request Aug 13, 2026
…nitialization (#1701)

## Description

This change adds a parser for the `MSEG_SMRAM_HOB` so that the SMM can
program the MSEG MSR during the first MMI entry.

This change also exposed the `efi_main` to make it discoverable in the
PDB file.

- [x] Impacts functionality?
- [x] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?

## How This Was Tested

This was tested on a customized QEMU Q35 platform and booted to UEFI
shell.

## Integration Instructions

For platforms elect to support SEA, integrate the MSEG prepare PEI into
the platform and link the STM based CPU feature library into the MM
initializer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact:security Has a security impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants