fix: stabilize live notch filter - #295
habibialireza wants to merge 1 commit into
Conversation
|
Visit the preview URL for this PR (updated for commit a2659f4): https://open-earable-web--pr295-fix-notch-filter-sta-otnqewak.web.app (expires Mon, 12 Oct 2026 18:15:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c7397c11177c71d8d81172cea9365829823fb41c |
PR Build Artifacts
Full workflow run: https://github.com/OpenEarable/app/actions/runs/34879380423 |
|
@habibialireza what was the problem? |
|
@TobiasRoeddiger The app treated every gap between sensor timestamps as a new sampling rate. Bluetooth delivery is slightly uneven, so It counted each small change in gaps as a new sampling rate and it recalculated the notch filter but with the states saved from previouse inputs. recalculating the notch filter’s coefficients for every gap made its output grow. The graph then slowed down while trying to draw those values. The existing safeguard only caught infinity. but the outputs reached high unmanagable sizes before reaching infinity. |
No description provided.