Skip to content

fix: stabilize live notch filter - #295

Open
habibialireza wants to merge 1 commit into
mainfrom
fix/notch-filter-stability
Open

habibialireza wants to merge 1 commit into
mainfrom
fix/notch-filter-stability

Conversation

@habibialireza

Copy link
Copy Markdown
Collaborator

No description provided.

@habibialireza habibialireza linked an issue Sep 14, 2026 that may be closed by this pull request
@github-actions

Copy link
Copy Markdown
Contributor

Visit the preview URL for this PR (updated for commit a2659f4):

https://open-earable-web--pr295-fix-notch-filter-sta-otnqewak.web.app

(expires Mon, 12 Oct 2026 18:15:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c7397c11177c71d8d81172cea9365829823fb41c

@github-actions

Copy link
Copy Markdown
Contributor

PR Build Artifacts

Full workflow run: https://github.com/OpenEarable/app/actions/runs/34879380423

@TobiasRoeddiger

Copy link
Copy Markdown
Member

@habibialireza what was the problem?

@habibialireza

Copy link
Copy Markdown
Collaborator Author

@TobiasRoeddiger The app treated every gap between sensor timestamps as a new sampling rate. Bluetooth delivery is slightly uneven, so It counted each small change in gaps as a new sampling rate and it recalculated the notch filter but with the states saved from previouse inputs. recalculating the notch filter’s coefficients for every gap made its output grow. The graph then slowed down while trying to draw those values. The existing safeguard only caught infinity. but the outputs reached high unmanagable sizes before reaching infinity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

app crashes with the 50 hz notch filter

2 participants