Skip to content

Feature/bmx160 new driver - #272

Open
mkuettner97 wants to merge 5 commits into
2.2.8from
feature/bmx160-new-driver
Open

mkuettner97 wants to merge 5 commits into
2.2.8from
feature/bmx160-new-driver

Conversation

@mkuettner97

Copy link
Copy Markdown
Collaborator

New bmx160 driver using the fifo and thus reducing load to the i2c bus and MCU

@mkuettner97
mkuettner97 requested a review from o-bagge September 7, 2026 13:46
@o-bagge
o-bagge changed the base branch from main to 2.2.8 September 8, 2026 12:15
@o-bagge
o-bagge force-pushed the feature/bmx160-new-driver branch from a95cbae to 804e9b8 Compare September 8, 2026 12:48
@o-bagge
o-bagge force-pushed the feature/bmx160-new-driver branch from 804e9b8 to 031f40c Compare September 8, 2026 14:14
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

✅ Unit tests passed

2 passed, 0 failed/error, 0 skippedview workflow run

Test scenario Platform Result
ring_buffer/openearable.unit.ring_buffer native_sim/native/64 ✅ passed
sensor_component/openearable.unit.sensor_component native_sim/native/64 ✅ passed

Download the unit-test-results artifact for full Twister reports and logs.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Build output available:
openearable_v2_firmware.elf.zip
openearable_v2_fota.zip

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Compiler warnings

The extended-warning build completed successfully.

Application compiler warnings

None.

View this workflow run

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Build output available:
openearable_v2_firmware.elf.zip
openearable_v2_fota.zip

Co-authored-by: o-bagge <47336932+o-bagge@users.noreply.github.com>
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Build output available:
openearable_v2_firmware.elf.zip
openearable_v2_fota.zip

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

CodeChecker static analysis (advisory)

Note

This report is informational. It does not block merging and does not change code.

At a glance

Scope Result
Findings on lines changed by this PR 2
Findings in the complete codebase 2
Analyzer invocations completed 162
Analyzer invocations failed 0

Findings on changed lines

Found 2 non-style issue(s) on lines changed by this PR.

Severity Location Analyzer/checker Message
HIGH src/SensorManager/BMX160/bosch/bmi160.c:2507 clangsa/core.UndefinedBinaryOperatorResult The left operand of '&' is a garbage value
HIGH src/SensorManager/BMX160/bosch/bmi160.c:5492 clangsa/core.UndefinedBinaryOperatorResult The left operand of '&' is a garbage value

Analyzer coverage

Analyzer Completed Failed
clangsa 81 0
cppcheck 81 0

Complete-codebase summary

Severity: 2 high
Reported by analyzer: clangsa: 2

Complete-codebase findings

Each finding includes source context. The > line and carets identify the expression reported by the analyzer.

Show detailed findings with source context (2 of 2)
HIGHsrc/SensorManager/BMX160/bosch/bmi160.c:2507 — The left operand of '&' is a garbage value
  2506 |             /* Set the FOC config for gyro */
> 2507 |             data = BMI160_SET_BITS(data, BMI160_GYRO_FOC_EN, foc_conf->foc_gyr_en);
       |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  2508 | 
HIGHsrc/SensorManager/BMX160/bosch/bmi160.c:5492 — The left operand of '&' is a garbage value
  5491 |     rslt |= bmi160_get_regs(addr, data, 2, dev);
> 5492 |     data[1] = data[1] & BMI160_FIFO_BYTE_COUNTER_MASK;
       |               ^^^^^^^
  5493 | 

Open the workflow run and download the complete CodeChecker report for a detailed view. Check out codechecker.html/index.html.

@o-bagge o-bagge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested streaming data to the phone and recorded at 800Hz to the SD card, and the data looks good with the new driver.
Note: this will probably conflict with PR #276, since this PR replaces DFRobot_BMX160, while #276 modifies and extends that old driver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants