Repository navigation
Fix stale beta firmware publication after artifact format change - #364
Merged
Merged
Conversation
✅ Unit tests passed2 passed, 0 failed/error, 0 skipped — view workflow run
Download the |
|
Build output available: |
Compiler warningsThe extended-warning build completed successfully. Application compiler warningsNone. |
CodeChecker static analysis✅ No non-style issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The beta publisher still downloads
openearable_v2_firmware.elf, but the NCS upgrade builds now provideopenearable_v2_firmware.zip. It skips PR #295 while reporting success, leaving the old 2.2.10 beta ZIP available even though the current build contains 2.3.0.Accept and package the new flash bundle, retaining the ELF fallback for older PRs. Preserve dots in asset titles so the app's filename fallback displays
2.3.0instead of2 3 0.Targets
mainbecause the publishing workflow runs from the default branch. No firmware code changes.Validation: exercised artifact collection and upload with modern ZIP, legacy ELF, missing firmware and missing FOTA fixtures; checked archive layout, version-name preservation and shell syntax. Downloaded PR #295's latest successful CI artifact and verified both its manifest and signed application header report 2.3.0. The previously published artifact reported 2.2.10.
Executed the corrected publisher from this branch in run 37431309589, which passed. The public
pr-295-2.3.0-openearable_v2_fota.zipnow reports 2.3.0 in both its manifest and signed image header; both image payloads match CI run 37356326611 byte-for-byte.