[dermatz]

Summary

Fixes four bugs in the Frontend Inspector and the shared shortcut parser that were found in a code review of src/.

Changes

Picker (inspector/picker.js)

• Toggling the inspector off while a badge is pinned left isPinned set. The next toggle-on then ignored mouse moves, so no element could be picked. toggleInspector() now uses closeInspector() when closing, like Escape does.
• After hovering an element, leaving it and hovering it again, the highlight did not come back because hoveredElement was not reset. It is now cleared when the highlight is hidden.
• this.floatingButton never existed (the field is _inspectorFloatButton), so the guards that ignore the floating button in handleMouseMove and handleClick never worked. They now use the real field.

Shortcut parser (shortcut-parser.js)

• event.key.toLowerCase() threw for keydown events without a key (e.g. browser autofill) on every such event. A missing key now simply does not match.
• On macOS, Option/Alt combined with a letter produces a special character in event.key (Option+I gives "ˆ"), so shortcuts like Cmd+Option+I never matched. When Alt/Option is part of the shortcut, letters and digits are now also matched through the physical key (event.code).

Accessibility tab (inspector/accessibility.js)

• An image with alt="" (a valid decorative image) was shown as red "Missing", while an image without any alt attribute was not shown at all. Now a missing attribute shows "⚠️ Missing" and an empty one shows "Empty (decorative)".

Testing

• The shortcut parser was checked with a Node script against Ctrl/Cmd+Shift+I, macOS Option+letter (including key values "ˆ" and "Dead"), events without key, a wrong physical key, function keys and none.
• trunk check on the three changed files is clean.
• There is no JavaScript test setup in the repository, so the picker and accessibility changes are not covered by automated tests and have not been run in a browser.

[Copilot]

🟡 Changes recommended

The physical-key fallback can trigger multiple actions when ordinary letters conflict with key codes and can activate shortcuts for events with a missing key.

2 open issues

• Ignore keyless events before physical-code fallback · New
• Restrict physical-key fallback to special or dead keys · New

What changed in this PR

This PR fixes Frontend Inspector picker state and image alt-text reporting, and improves the shared shortcut parser’s handling of missing keys and macOS Option shortcuts.

Changes:

• Reset picker state when closing or leaving a hovered element, and correct floating-button guards.
• Add physical-key matching for Alt/Option shortcuts and guard against missing key values.
• Distinguish missing image alt attributes from empty decorative alt text.

File	Description
src/​view/​frontend/​web/​js/​shortcut-parser.js	Adds missing-key handling and physical-key fallback for Alt/Option shortcuts.
src/​view/​frontend/​web/​js/​inspector/​picker.js	Fixes toggle cleanup, hover reset, and floating-button references.
src/​view/​frontend/​web/​js/​inspector/​accessibility.js	Reports missing and empty image alt attributes separately.

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

The physical-key fallback incorrectly matches Windows AltGr input as Ctrl+Alt shortcuts, causing callers to block character entry and trigger inspector or audit actions instead.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

Prevent AltGr input from matching Ctrl+Alt shortcuts

src/​view/​frontend/​web/​js/​shortcut-parser.js:103

The physical-key fallback also matches AltGr input on Windows layouts, where AltGr reports both ctrlKey and altKey. For example, typing @ with German AltGr+Q (key: "@", code: "KeyQ") now matches a configured Ctrl+Alt+Q shortcut. Both callers prevent the default action when matched, so typing the character instead toggles the inspector or audits. Exclude events reporting the AltGraph modifier from this fallback while preserving macOS Option matching.

2 resolved since last review

• Restrict physical-key fallback to special or dead keys
• Ignore keyless events before physical-code fallback

_{Review effort: Balanced}