Repository navigation
ci(trunk): pin pinact to 4.1.1 - #272
Merged
Merged
Conversation
pinact 5.0.2 fails with pinact/config-error on every workflow change because the trunk plugins still pass single-dash flags. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the pinact compatibility pin and accompanying explanatory comment.
No open issues 🎉
What changed in this PR
Pins pinact to 4.1.1 to avoid the Trunk plugin flag incompatibility that causes checks to fail on workflow changes, including PR #269.
Changes:
- Downgrades pinact from
5.0.2to4.1.1. - Adds a comment explaining the compatibility constraint and linking the upstream issue.
| File | Description |
|---|---|
.trunk/trunk.yaml |
Pins pinact to 4.1.1 and documents why it must remain on 4.x. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Trunk Checkjob fails withpinact/config-error: unknown flag: -formatfor every pull request that modifies a workflow file (seen on #269).pinact@5.0.2(introduced by the automatic trunk upgrade) is not supported by the trunk plugins:trunk-io/pluginsv1.11.0 still calls pinact with single-dash long flags, which pinact v5 rejects. The plugin declares 4.0.0 as its known good version. Upstream issue: trunk-io/plugins#1177Changes
pinactto4.1.1in.trunk/trunk.yamland document why in a comment.Testing
trunk checkon a copy of the new workflow from ci: check PR titles for Conventional Commits #269 reportsNo issueswith this change; before it reported thepinact/config-error.Follow-up
The weekly
trunk upgrademay proposepinact@5.xagain. Keep it on 4.x until the plugin issue is fixed.