feat(template): copy whole template directory with template:override by dermatz · Pull Request #275 · OpenForgeProject/mageforge

dermatz · 2026-11-06T13:51:10Z

Summary

mageforge:template:override now accepts a directory path and copies all files inside it (including subdirectories) into the theme.

bin/magento mageforge:template:override vendor/magepal/magento2-google-analytics4/view/frontend/templates -t Vendor/theme

Closes #245

Behaviour

Directory paths into a module's view/<area>/templates|email|web|layout (or a subdirectory), a Hyvä compat module or another theme's override directory are supported.
Each file is resolved through Magento's fallback chain (first match wins), so the copied files are the ones currently in use. Hyvä overrides still land in the original module's directory.
Already overridden files are skipped; --force replaces them with the next file in the chain.
--dry-run lists source → target for every file without copying.
After copying, every file is verified to resolve to the new override and the caches are cleaned.

Changes

TemplateReference: new isDirectory flag
TemplatePathParser: accepts directories
TemplateFallbackResolver::findDirectoryFiles(): merges files across fallback directories
OverrideCommand: directory flow
Docs and unit tests updated

Testing

phpunit tests/Unit: 751 tests pass
phpcs clean on changed files
Not yet tried manually against a Magento install (ddev magento m:t:o <dir> -t <theme>)

Closes #245 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

🟡 Changes recommended

Active issues cause incorrect discovery and skipped counts for theme-owned files without --force, and TypeErrors for numeric extensionless filenames at both resolver calls.

2 open issues

What changed in this PR

Extends mageforge:template:override to copy directories recursively into a theme, addressing #245 while using the existing Magento fallback and Hyvä compatibility handling.

Changes:

Adds directory references and parsing for module and theme view paths.
Merges files across fallback locations and adds bulk copying with skip, force, dry-run, verification and cache-cleaning behaviour.
Updates command documentation and unit tests.

File	Description
tests/Unit/Service/TemplateOverride/TemplatePathParserTest.php	Tests directory parsing and invalid paths.
tests/Unit/Service/TemplateOverride/TemplateFallbackResolverTest.php	Tests recursive merging and fallback precedence.
tests/Unit/Console/Command/Template/OverrideCommandTest.php	Tests directory copying, skipping and dry runs.
src/Service/TemplateOverride/TemplatePathParser.php	Parses module and theme directories, including compat mappings.
src/Service/TemplateOverride/TemplateFallbackResolver.php	Collects files recursively across fallback directories.
src/Model/TemplateReference.php	Adds a directory flag to template references.
src/Console/Command/Template/OverrideCommand.php	Implements the directory override flow and usage help.
docs/commands_reference.md	Documents directory inputs and replacement behaviour.

_{Review effort: Balanced}

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ric file names Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

🔵 Needs a closer look

Non-forced directory overrides incorrectly fail when templates exist only in the target theme because discovery excludes that directory instead of successfully skipping existing overrides.

No open issues 🎉

2 resolved since last review

_{Review effort: Balanced}

Copilot

🔵 Needs a closer look

Human assessment is needed because the new directory-mode tests do not exercise --force, leaving overwrite source selection, theme-only file preservation, and cache cleaning unverified on that path.

No open issues 🎉

_{Review effort: Balanced}

Copilot

🟡 Changes recommended

The directory-mode --force path lacks regression coverage for fallback-source replacement, preservation of theme-only files, and cache cleaning after replacements.

1 open issue

Add regression coverage for directory-mode --force replacement · New

_{Review effort: Balanced}

+        foreach ($sources as $relativePath => $sourceFile) {
+            // Numeric file names become integer array keys
+            $relativePath = (string) $relativePath;
+            if (isset($overridden[$relativePath]) && !$isForce) {


…asts Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

🔵 Needs a closer look

Human assessment is needed because a copy failure can leave a directory override partially applied with stale caches and no clear report of which files changed.

1 open issue

Add regression coverage for directory-mode --force replacement

_{Review effort: Balanced}

✨ feat(template): copy whole template directory with template:override

86ab46f

Closes #245 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI balanced review requested due to automatic review settings November 6, 2026 13:51

github-actions Bot added documentation Improvements or additions to documentation Feature Command labels Nov 6, 2026

Copilot started reviewing on behalf of dermatz November 6, 2026 13:51

View session

Copilot AI reviewed Nov 6, 2026

View reviewed changes

Comment thread src/Console/Command/Template/OverrideCommand.php Resolved

Comment thread src/Console/Command/Template/OverrideCommand.php Resolved

🎨 style(template): fix mago formatting and phpcs line length

a0aa09a

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI balanced review requested due to automatic review settings November 6, 2026 14:10

Copilot started reviewing on behalf of dermatz November 6, 2026 14:10

View session

dermatz changed the title ~~✨ feat(template): copy whole template directory with template:override~~ feat(template): copy whole template directory with template:override Nov 6, 2026

🐛 fix(template): count theme-only files as overridden and handle nume…

976a382

…ric file names Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI reviewed Nov 6, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings November 6, 2026 14:14

Copilot started reviewing on behalf of dermatz November 6, 2026 14:15

View session

Copilot AI reviewed Nov 6, 2026

View reviewed changes

Merge branch 'main' into feature/245-override-whole-template-directory

b84beba

Copilot AI balanced review requested due to automatic review settings November 6, 2026 14:23

Copilot started reviewing on behalf of dermatz November 6, 2026 14:24

View session

Copilot AI reviewed Nov 6, 2026

View reviewed changes

Comment thread src/Console/Command/Template/OverrideCommand.php

foreach ($sources as $relativePath => $sourceFile) {

// Numeric file names become integer array keys

$relativePath = (string) $relativePath;

if (isset($overridden[$relativePath]) && !$isForce) {

✅ test(template): cover directory override paths and drop redundant c…

c85c928

…asts Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI balanced review requested due to automatic review settings November 6, 2026 14:31

Copilot started reviewing on behalf of dermatz November 6, 2026 14:31

View session

Copilot AI reviewed Nov 6, 2026

View reviewed changes

Navigation Menu

Repository navigation

feat(template): copy whole template directory with template:override - #275

feat(template): copy whole template directory with template:override#275
dermatz wants to merge 5 commits into
mainfrom
feature/245-override-whole-template-directory

dermatz commented Nov 6, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

dermatz commented Nov 6, 2026

Summary

Behaviour

Changes

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants