Repository navigation
CORE-91: Adopt the corrected parent while preserving working Hashing coverage - #128
Draft
peter-lawrey wants to merge 1 commit into
Draft
peter-lawrey wants to merge 1 commit into
peter-lawrey wants to merge 1 commit into
Conversation
Prepare the reviewed Sonar repair as a draft. Keep publication and full CI/Sonar qualification pending; retain the existing thresholds.
peter-lawrey
changed the title
peter-lawrey
force-pushed
the
sonar/coverage-repair-2026-11-04
branch
from
November 5, 2026 08:58
4060b4c to
4ce8ffd
Compare
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for review. Parent publication status checked on 2026-11-05 at 12:53 UTC: the public root and Java
2026.0.1-sonar-SNAPSHOTparents are published and resolve in TeamCity. They remain mutable candidate snapshots; select and publish stable parent versions, update consumer coordinates and complete qualification before adoption.Hashing is the working coverage control and must remain working during parent adoption. Adopt the minimal 2026.0-based 2026.0.1-sonar-SNAPSHOT parent candidate. Preserve its existing late argument configuration and numerical thresholds.
Validation: Plain and Sonar effective models resolve on Maven 3.8.2 / JDK 11, with late binding, the empty default and active verify-phase coverage checks. Full mvn clean verify -Psonar passes with no failed tests and all coverage checks met.
Uses the published candidate Java-parent snapshot; stable parent publication remains required for adoption. Replace the candidate coordinate with the agreed released version before final adoption.
Full project/reactor qualification and fresh Sonar main/default/applicable PR analyses remain required. Existing coverage minima are unchanged; this candidate does not resolve measured coverage deficits by lowering them.
Local validation was performed on 2026-11-04 using Maven 3.8.2 / JDK 11 and an isolated Maven repository (TeamCity DSL: Maven 3.9.11 / JDK 11). No Sonar scanner or live server acceptance control was run as part of that validation.
Retained test XML: 14,906 tests, 8 skipped, 0 failures and 0 errors. Repeated Surefire executions may overwrite XML; these counts are not invocation totals.
Validated source base:
60af5802dfa1867ef286155e66503f7c20d8613b. This draft contains the exact reviewed candidate patch.Related parent and rollout drafts:
Live validation on 2026-11-05: Sonar build 1387836 ran at this PR head (
4ce8ffdb224d), loaded JaCoCo data, passed the coverage checks and uploaded a matching PR analysis. The PR gate was OK, but its returned conditions do not enforce coverage. This run used the legacy TeamCity template; it does not qualify the draft strict guards or theeabranch. The separate GitHub Actions Build check could not resolve this snapshot from its configured repositories; the passing TeamCity result does not clear that check. The scanner also reported 2 of 25 report files outside its analysed sources; reconcile that scope before claiming complete import.