Repository navigation
refactor(frontend): consolidate chessboards and wire unused components - #1446
Open
Maryermarh wants to merge 1 commit into
Open
Maryermarh wants to merge 1 commit into
Maryermarh wants to merge 1 commit into
Conversation
…e boards - Add a /game/[id]/review route that composes GameHistoryPGNViewer, CentipawnAdvantageChart, GameReviewSummary and PgnExportArchive; the game result overlay links to it and PlayGameEngine persists the finished PGN (FE-120 / OpenKnight-Foundation#1361) - Make TournamentBracketViewer the canonical bracket (richer navigation, spectating, Swiss standings) in the tournament page, delete the simpler BracketView, and remove the unused BerserkButton (FE-121 / OpenKnight-Foundation#1362) - Mount the previously-unreachable features at real routes: /simul (SimulHostDashboard), /offline (OfflinePlayView) and /watch/commentary (AudioCommentaryRoom) (FE-122 / OpenKnight-Foundation#1363) - Consolidate the chessboard implementations on ChessboardComponent: delete the unused OptimizedChessboard, keep Chessboard as a thin adapter, and put the WebGL board behind a new `boardRenderer` appearance setting (2D/3D) (FE-123 / OpenKnight-Foundation#1364) Closes OpenKnight-Foundation#1361 Closes OpenKnight-Foundation#1362 Closes OpenKnight-Foundation#1363 Closes OpenKnight-Foundation#1364
|
@Maryermarh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates the four chessboard implementations and mounts the
previously-unused simul, offline, commentary, tournament and review views.
Chessboardis now the single 2D board andChessboardWebGL3Disselectable through a new
boardRendererpreference (FE-123: Consolidate Four Chessboard Implementations #1364)OptimizedChessboard,BracketViewandBerserkButtoncomponents (FE-123: Consolidate Four Chessboard Implementations #1364)SimulHostDashboard,OfflinePlayViewandAudioCommentaryRoom(FE-122:SimulHostDashboard,OfflinePlayViewandAudioCommentaryRoomAre Never Mounted #1363)TournamentBracketViewer(FE-121:TournamentBracketViewerandBerserkButtonAre Unused — Tournament Page Uses the SimplerBracketView#1362)review summary (FE-120: Post-Game Review Components Are Built but Never Rendered #1361)
Closes #1361
Closes #1362
Closes #1363
Closes #1364