Repository navigation
feat(frontend): game clocks, resignation and navigation cleanup - #1448
Open
Muhammadjazuli wants to merge 1 commit into
Open
Muhammadjazuli wants to merge 1 commit into
Muhammadjazuli wants to merge 1 commit into
Conversation
…d 404 page - PlayGameEngine now initialises both clocks from the game's time control (?minutes=, default 10) instead of a hard-coded 600s, keeps treating server clock updates as authoritative, and ends the game with a loss on time when a flag falls (FE-116 / OpenKnight-Foundation#1357) - Resigning sends an explicit `{type:"resign"}` message before disconnecting so the server completes the game; the opponent is shown "won by resignation" via the new hook `opponentResigned` flag (FE-117 / OpenKnight-Foundation#1358) - Sidebar (desktop and mobile) now links to Tournaments, Puzzles, Companions, Guilds and Stake with active-route highlighting, and the dead /news, /profile and /support links were removed (FE-118 / OpenKnight-Foundation#1359, FE-119 / OpenKnight-Foundation#1360) - Add a branded app/not-found.tsx and an app/guilds index so every sidebar entry resolves (FE-118 / OpenKnight-Foundation#1359, FE-119 / OpenKnight-Foundation#1360) Closes OpenKnight-Foundation#1357 Closes OpenKnight-Foundation#1358 Closes OpenKnight-Foundation#1359 Closes OpenKnight-Foundation#1360
|
@Muhammadjazuli Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds server-driven game clocks and proper resignation, fixes dead sidebar
links, and provides the missing navigation entries plus a 404 page.
PlayGameEngineacceptsinitialMinutes, tracksflaggedColor, and endsthe game with a loss when a player's flag falls (FE-116: Game Clocks Are Client-Side Only, Fixed at 10 Minutes, and Running Out of Time Doesn't End the Game #1357)
resignmessage over the socket and the opponentreceives a
win_by_resignationresult (FE-117: Resigning Only Closes the Local Socket — the Opponent and Server Are Never Told #1358)/news,/profileand/supportlinks and addsTournaments, Puzzles, Companions, Guilds and Stake (FE-118: Sidebar Links to
/news,/profileand/supportLead to 404s, and There Is No Custom 404 Page #1359, FE-119: Tournament, Puzzles, Stake, Guilds and Companions Pages Are Missing From Navigation #1360)not-found.tsxand a mockguildsdirectory pageCloses #1357
Closes #1358
Closes #1359
Closes #1360