Skip to content

fix: reuse shared connection status components in PlayGameEngine - #1449

Open
Hakimi674 wants to merge 3 commits into
OpenKnight-Foundation:mainfrom
Hakimi674:fix/issue-1366-fe-125-reconnectionbanner-and
Open

Hakimi674 wants to merge 3 commits into
OpenKnight-Foundation:mainfrom
Hakimi674:fix/issue-1366-fe-125-reconnectionbanner-and

Conversation

@Hakimi674

Copy link
Copy Markdown

Overview

This PR removes the hand-rolled connection-status UI in PlayGameEngine and wires in the existing shared components (ReconnectionBanner and ConnectionStatusIndicator), consolidating the duplicated implementation into a single source of truth.

Related Issue

Changes

🔌 Connection Status Consolidation

  • [MODIFY] frontend/components/chess/PlayGameEngine.tsx

    • Removed the inline socketStatusLabel() rendering (previously at lines 323-345).
    • Now renders the shared ConnectionStatusIndicator for the compact status display and ReconnectionBanner for the reconnection notice.
  • [MODIFY] frontend/components/ReconnectionBanner.tsx

    • Adjusted so it can be consumed by PlayGameEngine (props/rendering aligned with the engine's connection state).
  • [MODIFY] frontend/components/chess/ConnectionStatusIndicator.tsx

    • Adjusted so it can be consumed by PlayGameEngine (props/rendering aligned with the engine's connection state).

Verification Results

Manual check:
✅ PlayGameEngine renders shared ConnectionStatusIndicator instead of socketStatusLabel()
✅ ReconnectionBanner displays on disconnect/reconnect flow
✅ No remaining hand-rolled connection-status markup in PlayGameEngine
Acceptance Criteria Status
Use the shared components in PlayGameEngine (and the home page online bar) ✅ PlayGameEngine now uses ReconnectionBanner + ConnectionStatusIndicator
Delete whichever implementation is not kept ✅ Inline socketStatusLabel() UI removed from PlayGameEngine

Closes #1366

@drips-wave

drips-wave Bot commented Oct 17, 2026

Copy link
Copy Markdown

@Hakimi674 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FE-125: ReconnectionBanner and ConnectionStatusIndicator Are Unused While PlayGameEngine Hand-Rolls Its Own

1 participant