Repository navigation
Conversation
…server reachable - Bind the WebSocket server to AGENT_WS_HOST/AGENT_WS_PORT (default 0.0.0.0:8765), EXPOSE the port, and close the server on shutdown (OpenKnight-Foundation#1421) - Switch to the single-argument websockets handler, read the path from websocket.request.path, and pin websockets>=13,<16 (OpenKnight-Foundation#1424) - Rebuild the Dockerfile: copy source before install, install into a venv owned by appuser, install Stockfish, select it via ENGINE_BACKEND; add .dockerignore and a CI job that builds the image and does a WebSocket round-trip (OpenKnight-Foundation#1425) - Remove the stale tracked build/ directory and ignore build/ and dist/ (OpenKnight-Foundation#1426) - Fix signal handler registration (asyncio.SIGINT -> signal.SIGINT) that crashed main() Closes OpenKnight-Foundation#1421, closes OpenKnight-Foundation#1424, closes OpenKnight-Foundation#1425, closes OpenKnight-Foundation#1426 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@feyishola Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1421, closes #1424, closes #1425, closes #1426
#1421: WebSocket server bound to localhost
main.pyreadsAGENT_WS_HOSTandAGENT_WS_PORT(default0.0.0.0:8765). The Dockerfile hasEXPOSE 8765.shutdown()now closes the WebSocket server.#1424: Legacy
(websocket, path)handlerwebsocket.request.path.websocketswas not declared as a dependency. It is now pinned to>=13.0,<16.#1425: Docker image couldn't run
pyproject.toml,README.mdandgpu_worker/beforepip install, and installs into/opt/venv, owned byappuser.STOCKFISH_PATH=/usr/games/stockfishandENGINE_BACKEND=stockfish..dockerignore.docker-buildCI job:import gpu_workeruci#1426: Stale
build/directoryagent-engines/build/.build/,dist/and*.egg-info/toagent-engines/.gitignore. I scoped this toagent-engines/so the rules don't affect other packages in the monorepo.Two other fixes needed for the container to start
main()registered signal handlers withgetattr(asyncio, 'SIGINT'), which doesn't exist, so the process crashed at startup. It now uses thesignalmodule.ENGINE_BACKEND. Without it, the default is still lc0.Test plan
docker buildsucceeds.import gpu_workerworks,websocketsis 15.0.1, and Stockfish 17.1 responds touci.-p. A client on the host sent messages and got the expected replies, and the server logged the request path.docker stop(SIGTERM) shuts down cleanly.pytest tests: 503 passed and 6 skipped, the same asmain.test_orchestrator.py: 3 passed.🤖 Generated with Claude Code