Repository navigation
fix(frontend): restore type-check and lint after the latest merges - #1454
Merged
Merged
Conversation
- SignInModal: #1450 wired AuthGate and Header to a sign-in modal but never added it (the file was still a commented-out stub). Implement it against authContext login/register, accepting both open/onOpenChange and isOpen/onClose, with the test ids the sign-in e2e specs use. - Header: header-sign-in / header-username test ids; show the username. - authContext: fix the base644 typo in decodeJWT and a stray quote (#1450). - PlayGameEngine (#1449): pass ReconnectionBanner the isDisconnected flag it expects; ConnectionStatusIndicator takes optional reconnectAttempts, latency and className.
- Sign in: the app shell (ClientRoot) never rendered Header, so no page had a sign-in button. Add AuthButton (header-sign-in / header-username) to the shell; mock **/auth/login in both sign-in specs (the app calls $API_BASE/v1/auth/login, which neither mocked URL matched). - Landing: label the bots button so both /play bots/ and /play vs bot/ match. - Watch: target the 'Live games lobby' region (two regions matched). - Staking: sendXLM's fallback resubmitted the raw XDR string, which always threw "reading 'type'" and hid the real error; drop it. The Horizon mock now includes _links, which stellar-sdk needs to expose data_attr for its memo-required check. - Game vs bot: squares are labelled 'e4, White Pawn' / 'e4, empty'.
…build time - Chessboard visual-regression baselines, rendered by the CI runner. - NEXT_PUBLIC_STAKING_ESCROW_ADDRESS is inlined by next build, so setting it only on the Playwright webServer left the staking spec with 'Staking escrow is not configured.'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes left on main after merging #1445–#1453 (6 type errors and 1 lint error).
AuthGateandHeaderto a sign-in modal but never added the modal itself;components/SignInModal.tsxwas still a commented-out stub. This implements it againstauthContext'slogin/register. It accepts both prop styles its callers use (open/onOpenChangeandisOpen/onClose) and carries the test ids the sign-in e2e specs expect.header-sign-inandheader-usernametest ids and shows the signed-in username.base644typo indecodeJWT(it would throw on every token) and a stray quote in a comment.ReconnectionBannertheisDisconnectedflag it expects.ConnectionStatusIndicatornow takes optionalreconnectAttempts,latencyandclassName.Locally:
tschas 0 errors, lint is clean, and all 310 unit tests pass.