Make the FLOPS BWB work with Tabular Cruise aero. - #1302
Open
Kenneth-T-Moore wants to merge 3 commits into
Open
Kenneth-T-Moore wants to merge 3 commits into
Kenneth-T-Moore wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The FLOPS BWB wouldn't make it through setup due to a couple of bugs.
check_and_preprocess_inputsso that we don't create any GASP geometry if the core method is FLOPS and we are only using GASP because of tabular_cruise.NOTE: We should ultimately eliminate the need to set the aero_method to GASP just to use tabular cruise.
Related Issues
Backwards incompatibilities
None
AI Usage
Disclose any AI usage in this PR, including models used and files affected.