Fix a bug where the preprocessor did not properly warn about an inconsistent set of design passengers. - #1303
Merged
Merged
Conversation
jkirk5
approved these changes
Sep 17, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 17, 2026
jkirk5
approved these changes
Sep 18, 2026
jkirk5
enabled auto-merge
September 18, 2026 19:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a bug where the preprocessor was not warning if the number of design passengers did not equal the sum of the individual class passenger counts (where the user had forgotten one of the classes.)
Fixed an additional bug where a few vars were undefined if you chose to use detailed cabin layout on a transport.
Related Issues
Backwards incompatibilities
None
AI Usage
Disclose any AI usage in this PR, including models used and files affected.