Conversation
Mostly gained by tightening some solver tolerances
…into freighter_model
…into freighter_model
Contributor
Author
|
The 2DOF throttle allocation test always returns a 50/50 split between the engines which definitely seems wrong, and I will need to dig in a little more to verify it is actually working |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added multiengine capability to 2dof mission analysis. The throttle allocator was added for phases that actually used throttle as a control (basically just cruise), while the other phases had throttle shape set to be able to accept multiple throttles per node. Nothing was changed about how throttle was used for each phase, so they are still mostly user-set static values per-phase.
I think there is potential to consolidate the existing
add_throttle_controlin 2dof ODEs with the updatedadd_subsystems_and_solverpresent in all ODES (from BaseODE class).Related Issues
Backwards incompatibilities
None
AI Usage
AI was used to:
PercentNotInFuselagecomponent of geometry/gasp_based/engine.py to support multiengine