Removed all uses of get_option_defaults - #1305
Draft
hschilling wants to merge 2 commits into
Draft
hschilling wants to merge 2 commits into
hschilling wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes reliance on get_option_defaults() (which silently pulls in every metadata default plus a hidden default engine deck) across ~20 test files. Each test now builds a minimal AviaryValues() containing only the options its model actually declares/uses, making test dependencies explicit and self-documenting. No behavior or expected values changed; get_option_defaults() itself is untouched for remaining callers.
Related Issues
get_option_defaults#1251Backwards incompatibilities
None
AI Usage
All files in this PR contain code generated using Claude Sonnet 5.