feat: add Rotating Detonation Engine (RDE) combustor element, cycles, and benchmarks - #121
Open
arushkumarsingh wants to merge 7 commits into
Open
arushkumarsingh wants to merge 7 commits into
arushkumarsingh wants to merge 7 commits into
Conversation
…ion scripts, and example cycles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces the Rotating Detonation Engine (RDE) combustor element (
RDECombustor), along with associated cycle models, regression benchmarks, and diagnostic viewers for pressure-gain combustion (PGC) in pyCycle.Key Additions:
RDECombustorElement (pycycle/elements/rde_combustor.py):CEAandTABULARthermodynamics, as well as on-design Mach number and off-design throat area matching modes.pycycle.apiaspyc.RDECombustorandpyc.print_rde.Cycle Examples:
example_cycles/rde_ramjet.py):example_cycles/rde_turbojet.py):OD0).Verification & Regression Benchmark Test Suites:
pycycle/elements/test/test_rde_combustor.py):check_partials(method='cs')).example_cycles/tests/benchmark_rde_turbojet.py: Multi-point regression against locked tolerances forDESIGNandOD0.example_cycles/tests/benchmark_rde_ramjet.py: High-speed ramjet regression benchmarks.Related Issues
Backwards Incompatibilities
None. All existing Brayton cycle elements (
Combustor,Compressor,Turbine, etc.) and all existing cycle examples/tests are preserved without modification.New Dependencies
None.