Skip to content

Don't check LDU in LAPACKE_?GESVD_WORK when U is not used (from Reference-LAPACK PR 1284) #5856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martin-frbg merged 1 commit into from
Jun 25, 2026
+44 −36
Merged

Don't check LDU in LAPACKE_?GESVD_WORK when U is not used (from Reference-LAPACK PR 1284) #5856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions lapack-netlib/LAPACKE/src/lapacke_cgesvd_work.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,17 +69,19 @@ lapack_int LAPACKE_cgesvd_work( int matrix_layout, char jobu, char jobvt,
LAPACKE_xerbla( "LAPACKE_cgesvd_work", info );
return info;
}
if( ldu < ncols_u ) {
info = -10;
LAPACKE_xerbla( "LAPACKE_cgesvd_work", info );
return info;
if( LAPACKE_lsame( jobu, 'a' ) || LAPACKE_lsame( jobu, 's' ) ) {
if( ldu < ncols_u ) {
info = -10;
LAPACKE_xerbla( "LAPACKE_cgesvd_work", info );
return info;
}
}
if( LAPACKE_lsame( jobvt, 'a' ) || LAPACKE_lsame( jobvt, 's' ) ) {
if( ldvt < ncols_vt ) {
info = -12;
LAPACKE_xerbla( "LAPACKE_cgesvd_work", info );
return info;
}
if( ldvt < ncols_vt ) {
info = -12;
LAPACKE_xerbla( "LAPACKE_cgesvd_work", info );
return info;
}
}
/* Query optimal working array(s) size if requested */
if( lwork == -1 ) {
Expand Down
20 changes: 11 additions & 9 deletions lapack-netlib/LAPACKE/src/lapacke_dgesvd_work.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,17 +67,19 @@ lapack_int LAPACKE_dgesvd_work( int matrix_layout, char jobu, char jobvt,
LAPACKE_xerbla( "LAPACKE_dgesvd_work", info );
return info;
}
if( ldu < ncols_u ) {
info = -10;
LAPACKE_xerbla( "LAPACKE_dgesvd_work", info );
return info;
if( LAPACKE_lsame( jobu, 'a' ) || LAPACKE_lsame( jobu, 's' ) ) {
if( ldu < ncols_u ) {
info = -10;
LAPACKE_xerbla( "LAPACKE_dgesvd_work", info );
return info;
}
}
if( LAPACKE_lsame( jobvt, 'a' ) || LAPACKE_lsame( jobvt, 's' ) ) {
if( ldvt < ncols_vt ) {
info = -12;
LAPACKE_xerbla( "LAPACKE_dgesvd_work", info );
return info;
}
if( ldvt < ncols_vt ) {
info = -12;
LAPACKE_xerbla( "LAPACKE_dgesvd_work", info );
return info;
}
}
/* Query optimal working array(s) size if requested */
if( lwork == -1 ) {
Expand Down
20 changes: 11 additions & 9 deletions lapack-netlib/LAPACKE/src/lapacke_sgesvd_work.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,17 +67,19 @@ lapack_int LAPACKE_sgesvd_work( int matrix_layout, char jobu, char jobvt,
LAPACKE_xerbla( "LAPACKE_sgesvd_work", info );
return info;
}
if( ldu < ncols_u ) {
info = -10;
LAPACKE_xerbla( "LAPACKE_sgesvd_work", info );
return info;
if( LAPACKE_lsame( jobu, 'a' ) || LAPACKE_lsame( jobu, 's' ) ) {
if( ldu < ncols_u ) {
info = -10;
LAPACKE_xerbla( "LAPACKE_sgesvd_work", info );
return info;
}
}
if( LAPACKE_lsame( jobvt, 'a' ) || LAPACKE_lsame( jobvt, 's' ) ) {
if( ldvt < ncols_vt ) {
info = -12;
LAPACKE_xerbla( "LAPACKE_sgesvd_work", info );
return info;
}
if( ldvt < ncols_vt ) {
info = -12;
LAPACKE_xerbla( "LAPACKE_sgesvd_work", info );
return info;
}
}
/* Query optimal working array(s) size if requested */
if( lwork == -1 ) {
Expand Down
20 changes: 11 additions & 9 deletions lapack-netlib/LAPACKE/src/lapacke_zgesvd_work.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,17 +69,19 @@ lapack_int LAPACKE_zgesvd_work( int matrix_layout, char jobu, char jobvt,
LAPACKE_xerbla( "LAPACKE_zgesvd_work", info );
return info;
}
if( ldu < ncols_u ) {
info = -10;
LAPACKE_xerbla( "LAPACKE_zgesvd_work", info );
return info;
if( LAPACKE_lsame( jobu, 'a' ) || LAPACKE_lsame( jobu, 's' ) ) {
if( ldu < ncols_u ) {
info = -10;
LAPACKE_xerbla( "LAPACKE_zgesvd_work", info );
return info;
}
}
if( LAPACKE_lsame( jobvt, 'a' ) || LAPACKE_lsame( jobvt, 's' ) ) {
if( ldvt < ncols_vt ) {
info = -12;
LAPACKE_xerbla( "LAPACKE_zgesvd_work", info );
return info;
}
if( ldvt < ncols_vt ) {
info = -12;
LAPACKE_xerbla( "LAPACKE_zgesvd_work", info );
return info;
}
}
/* Query optimal working array(s) size if requested */
if( lwork == -1 ) {
Expand Down
Loading