E001 update tests#439
Conversation
4ce8804 to
a73e331
Compare
44e0713 to
0487757
Compare
[test_*] reorder imports [tests_ModelicaDoE*] fix pylint hint * use .items() [tests_*] use OMSessionABC.get_version() [test_ModelicaSystemCmd] use get_model_name() instead of access to private variable _model_name [test_ModelicaSystemOMC] read file using utf-8 encoding / linter fix [test_ModelicaSystemRunner] update test case * ModelicaSystemRunner & OMCPath * ModelicaSystemRunner & OMPathRunnerLocal * ModelicaSystemRunner & OMPathRunnerBash * ModelicaSystemRunner & OMPathRunnerBash using docker * ModelicaSystemRunner & OMPathRunnerBash using WSL (not tested!) [test_OMCPath] update test case * OMCPath & OMCSessionZMQ * OMCPath & OMCSessionLocal * OMCPath & OMCSessionDocker * OMCPath & OMCSessionWSL (not tested!) * OMPathLocal & OMCSessionRunner * OMPathBash & OMCSessionRunner * OMPathBash & OMCSessionRunner in docker * OMPathBash & OMCSessionRunner in WSL (not tested!) add workflow to run unittests in ./tests [test_OMParser] use only the public interface => om_parser_basic() [test_OMTypedParser] rename file / use om_parser_typed() update tests - do NOT run test_FMIRegression.py reason: * it is only a test for OMC / not OMPython specific * furthermore, it is run automatically via cron job (= FMITest) [test_ModelExecutionCmd] rename from test_ModelicaSystemCmd
0487757 to
043fb27
Compare
|
The simulation on Windows takes more time. Increase the default timeout of 10s in OMCSession/ModelicaSystem. |
5f60214 to
4795464
Compare
* windows unittests on github need a longer time to run the tests
4795464 to
72a18da
Compare
|
it is now down to docker / windows failing |
aae87fb to
a5ff0a1
Compare
|
I updated the timeout to 5 mins but it still fails. I think something is stuck when running |
|
Running the test alone works fine https://github.com/OpenModelica/OMPython/actions/runs/26285383965/job/77371637784?pr=439 I will debug more. |
|
If i run pytest with |
|
I still haven't got enough time to look into this. Will try to debug this more asap. |
|
@adeas31 Any point where I can help? |
I will let you know. |
|
This seems to work fine with increased timeout of workflow The FMI import tests were failing for Windows. I am trying to get them fixed in OpenModelica OpenModelica/OpenModelica#15864. For now I have skipped the test to see if this PR passes. |
There was a problem hiding this comment.
This works finally.
I added inputs for pytest in the workflow and increased the workflow timeout.
Also increased the command execution timeout from 10 secs to 5 minutes. I noticed that the timeout is defined in OMCSession, ModelExecutionCmd and ModelicaSystemCmd. AFAIU we only need it defined in OMCSession. ModelExecutionCmd uses the timeout from OMCSession and ModelicaSystemCmd then uses ModelExecutionCmd. Perhaps we can improve this in another PR. For now I will merge this one.
(E001) update tests (v4.x.x)