Skip to content

fix crash when some long cam-id copy #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agalasso merged 1 commit into from
Sep 12, 2026
Merged

fix crash when some long cam-id copy #1466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/cam_qhy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ class Camera_QHY : public GuideCamera
double m_usbTrafficStep;
bool m_hasUsbTraffic;

char m_camId[32] = "";
char m_camId[CAMERA_ID_LENGTH] = "";
double m_devicePixelSize;
unsigned char *RawBuffer;
wxSize m_maxSize;
Expand Down Expand Up @@ -395,7 +395,7 @@ void Camera_QHY::ShowPropertyDialog()
QHYCameraDlg dlg;
bool reconnect = false;

char camShortName[32] = "";
char camShortName[CAMERA_ID_LENGTH] = "";
GetQHYCCDModel(m_camId, camShortName);

dlg.SetTitle(wxString::Format("%s Settings", camShortName));
Expand Down Expand Up @@ -552,7 +552,7 @@ bool Camera_QHY::EnumCameras(wxArrayString& names, wxArrayString& ids)
int n = 1;
for (int i = 0; i < num_cams; i++)
{
char camid[32] = "";
char camid[CAMERA_ID_LENGTH] = "";
GetQHYCCDId(i, camid);
bool st4 = false;
qhyccd_handle *h = OpenQHYCCD(camid);
Expand Down