Skip to content

indi camera: image format minor refactor - #1473

Merged
agalasso merged 2 commits into
masterfrom
andy/indi-frame-format-minor-refactor
Oct 21, 2026
Merged

agalasso merged 2 commits into
masterfrom
andy/indi-frame-format-minor-refactor

Conversation

@agalasso

Copy link
Copy Markdown
Contributor

indi camera: image format minor refactor

Centralize image format detection and handling at the time the image is
received.

Also, use wxWidgets C-string wrappers for portability.

Centralize image format detection and handling at the time the image is
received.

Also, use wxWidgets C-string wrappers for portability.
@agalasso agalasso self-assigned this Oct 20, 2026
@agalasso
agalasso requested a review from bwdev01 October 20, 2026 17:13
@agalasso

Copy link
Copy Markdown
Contributor Author

@MichaelJEvan please review (github wouldn't let me add you to the list of reviewers)

@MichaelJEvan MichaelJEvan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested on macOS arm64 (native build) with INDI 2.2.2 Guide Simulator + Telescope Simulator:

  • .fits (compression off): 120 s guiding, calibration, dither/settle, pause/resume, calibration flip: all pass, no frames lost.
  • .fits.fz (compression on, frames ~730 KB vs 2.6 MB): same tests, all pass.
  • Unknown format (CCD_TRANSFER_FORMAT = Native, the simulator sends .bin): "Unknown image format: .bin" alert and capture stops, as before.

Code reads fine; bounding the compare by sizeof(bp->format) keeps .fits from matching .fits.fz. One small thing, not blocking: the video-stream path also calls steal(), so each streamed frame now builds an "Unknown image format" message that StackStream doesn't use.

Looks good to me, thanks for the cleanup.

@agalasso

Copy link
Copy Markdown
Contributor Author

the video-stream path also calls steal()

@MichaelJEvan Thanks for catching that! I pushed another commit to handle this more gracefully.

@agalasso
agalasso merged commit 70e9fd1 into master Oct 21, 2026
2 checks passed
@agalasso
agalasso deleted the andy/indi-frame-format-minor-refactor branch October 21, 2026 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants