Repository navigation
indi camera: image format minor refactor - #1473
Merged
Merged
Conversation
Centralize image format detection and handling at the time the image is received. Also, use wxWidgets C-string wrappers for portability.
Contributor
Author
|
@MichaelJEvan please review (github wouldn't let me add you to the list of reviewers) |
MichaelJEvan
approved these changes
Oct 20, 2026
MichaelJEvan
left a comment
Contributor
There was a problem hiding this comment.
Reviewed and tested on macOS arm64 (native build) with INDI 2.2.2 Guide Simulator + Telescope Simulator:
.fits(compression off): 120 s guiding, calibration, dither/settle, pause/resume, calibration flip: all pass, no frames lost..fits.fz(compression on, frames ~730 KB vs 2.6 MB): same tests, all pass.- Unknown format (
CCD_TRANSFER_FORMAT= Native, the simulator sends.bin): "Unknown image format: .bin" alert and capture stops, as before.
Code reads fine; bounding the compare by sizeof(bp->format) keeps .fits from matching .fits.fz. One small thing, not blocking: the video-stream path also calls steal(), so each streamed frame now builds an "Unknown image format" message that StackStream doesn't use.
Looks good to me, thanks for the cleanup.
Contributor
Author
@MichaelJEvan Thanks for catching that! I pushed another commit to handle this more gracefully. |
bwdev01
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
indi camera: image format minor refactor
Centralize image format detection and handling at the time the image is
received.
Also, use wxWidgets C-string wrappers for portability.