Repository navigation
dotnet10 bump! (PR 1 of 2) - #827
Open
baumannalexj wants to merge 1 commit into
Open
baumannalexj wants to merge 1 commit into
baumannalexj wants to merge 1 commit into
Conversation
- OpenRA.Mods.RA2.csproj: make EngineRootPath a conditioned default (overridable via -p:EngineRootPath=... or an EngineRootPath env var) instead of an unconditional assignment, so the mod can be pointed at an arbitrary engine checkout without a ./engine symlink/junction. - Add OpenRA.Mods.RA2.Test (NUnit), matching the engine's own OpenRA.Test project layout. EngineCompatibilityTests reflects over ChronoResourceDelivery and WithVoxelHelicopterBodyInfo to assert they still satisfy INotifyHarvesterAction and IRenderActorPreviewVoxelsInfo respectively - these traits implement engine-supplied interfaces directly (the trait system is the composition root), so there's no adapter layer to shield them from upstream interface changes. Verified red on release-20250330, green on release-20231010. - Ignore .worktrees (used for nested engine-bump worktrees). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YSDurhbS9Xa3qhBxcHSFFb
baumannalexj
changed the title
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.