fix: match .editorconfig to actual practice - #2259
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s .editorconfig C# newline/brace formatting rules with the stated goal of aligning Visual Studio formatting behavior with existing code so that formatting does not introduce diffs.
Changes:
- Switches several C# “new line preferences” settings (open braces,
catch/else/finally, and initializer member layout) to new-line style defaults.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| csharp_new_line_before_open_brace = all | ||
| csharp_new_line_before_catch = true | ||
| csharp_new_line_before_else = true | ||
| csharp_new_line_before_finally = true | ||
| csharp_new_line_before_members_in_anonymous_types = true | ||
| csharp_new_line_before_members_in_object_initializers = true |
|
@brunom would not this break the java style code blocks used in all files ? |
|
I found out .editorconfig didn't match DisassemblyViewModel.cs while fixing #2260 |
|
@brunom thanks for raising the issue, I wasn't aware of it. Will fix it sometime later with dotnet format. Is it OK for you if this PR is closed ? |
|
Sure, thanks. |
Now Visual Studio formatting leaves files unchanged. Tested on src/Spice86/ViewModels/DisassemblyViewModel.cs