Skip to content

Restore reviewed translations and fix station tab wrapping - #320

Merged
salbahra merged 2 commits into
masterfrom
fix/translation-overrides-and-de-tabs
Oct 23, 2026
Merged

salbahra merged 2 commits into
masterfrom
fix/translation-overrides-and-de-tabs

Conversation

@rayshobby

Copy link
Copy Markdown
Member

Summary

  • Restore reviewed wording where Transifex imports introduced incorrect translations. Comparing compiled dictionaries before and after the pull revealed clear errors, such as Spanish “Dutch” becoming “German” and Slovak “Italian” and “Latvian” being swapped. Local overrides protect the corrections; contributions that were equally good or better are retained.
  • Add import warnings and a persistent coverage report when Transifex wording replaces reviewed AI translations. Translation precedence is unchanged, and reports do not fail CI.
  • Reduce station-tab padding and shorten Swedish/Norwegian labels to improve wrapping.

Corrections were reviewed by LLMs; native-speaker feedback remains welcome. Incorrect source translations should also be corrected on Transifex.

Testing

  • 37 translation tests and 573 app tests passed.
  • All 31 dictionaries verified; ESLint and CSS lint clean.
  • Station tabs checked with all languages on a live controller. Only Tamil still wraps, onto two usable rows.

rayshobby and others added 2 commits October 22, 2026 22:26
…rapping

The Transifex pull in 57f8ddf filled strings that already had reviewed
machine translations, so the new text took effect without review. Several
values are wrong, e.g. es Dutch as "Alemán", sk Italian/Latvian swapped,
he Latvian/Slovenian naming other languages. Pin the reviewed wording as
overrides in de, es, cs, sk and he where the incoming text is wrong or
worse, and keep incoming values that are equal or better. Also pin correct
language names in am and no where two languages shared one name.

Reduce station attribute tab padding to 10px so the tab bar fits on one
row in German, Bulgarian, Mongolian, Polish and Russian, and pin shorter
"Basic" labels for Swedish and Norwegian, used only by this tab.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A Transifex pull could replace reviewed machine wording in the compiled UI
without any warning, since the importer only reported conflicts with
overrides. importPO now lists each newly imported value that replaces
reviewed wording, and translations:coverage keeps every current case in
reviewedReplaced. Override-protected keys, identical wording and
unreviewed drafts are excluded.

Both reports are informational: precedence is unchanged, CI does not fail,
and reviewers either accept the human wording or pin the reviewed text
with an override.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T13:12:37.745116Z 770648c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 770648c):

https://opensprinkler-devui--pr320-fix-translation-over-73akzhbc.web.app

(expires Fri, 30 Oct 2026 13:11:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 9b7a984849dffe48c01bc0242f5c0f93b14ed1df

@salbahra
salbahra merged commit d1c8fe5 into master Oct 23, 2026
7 checks passed
@salbahra
salbahra deleted the fix/translation-overrides-and-de-tabs branch October 23, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants