Skip to content

Support multiday for local provider - #170

Closed
rayshobby wants to merge 1 commit into
masterfrom
local-multiday
Closed

rayshobby wants to merge 1 commit into
masterfrom
local-multiday

Conversation

@rayshobby

@rayshobby rayshobby commented Sep 10, 2025 •

Copy link
Copy Markdown
Member

This branch add multiday support for the local weather provider. It's similar to #169 but the implementation might be a bit different. It splits the data such that each whole day is midnight to midnight, which is consistent with all other providers.

… midnight, so it's consistent with all other providers; make indentations consistent
@rmloeb

rmloeb commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

Only had a few minutes to scan the code. Does this code cache the last three days of observations from a local weatherstation? Just curious ('cause that's what I need for my installations).

@NickM-27

Copy link
Copy Markdown

It stores the last 7 days (as opposed to before where only the last day was stored). The most recent 3 of those 7 days would be used when that feature is enabled

@rmloeb

rmloeb commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

Thank you very much!!!

@rayshobby

Copy link
Copy Markdown
Member Author

It caches up to the past 7 days. When you send a query, it will use as many days of data as there is available. For example, if you do have all 7 days of data, it can return an array of size 7. If there is only 1 day of data available, the return is of size 1.

@NickM-27

Copy link
Copy Markdown
Screen Shot 2025-09-11 at 07 03 30 AM

rayshobby added a commit that referenced this pull request Aug 10, 2026
Retain eight days of local PWS observations and return up to seven contiguous complete calendar days for interval-program averaging. Time-weight irregular samples across day boundaries while preserving optional wind and solar data.

Normalize all provider history newest-first, reject duplicate or noncontiguous days, validate hourly slots across DST transitions, and correct Pirate Weather handling of 23- and 25-hour days. Extend deterministic and live local-PWS coverage accordingly.

Reimplements #170 against the current provider architecture.
@rayshobby

Copy link
Copy Markdown
Member Author

Multi-day local-provider history has now been implemented in an updated form through #180 and released in Weather Service 3.1.0, including calendar-day normalization and persistence across restarts. Closing this superseded PR.

@rayshobby rayshobby closed this Aug 12, 2026
@rayshobby
rayshobby deleted the local-multiday branch August 12, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants