Repository navigation
Restore WU adjustments without solar data - #182
Merged
Merged
Conversation
Allow Weather Underground history to remain usable when a personal weather station does not provide optional wind or solar measurements. Apply the legacy zero fallback only when a measurement is absent throughout the returned history, while preserving 3.1.0 truncation and error behavior for intermittent sensor gaps. Keep cached provider data unchanged so WeatherSensor output still distinguishes unavailable values from measured zeroes. Add regression coverage for WU, Zimmerman, ETo, and WeatherSensor behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regression
Weather Server 3.1.0 required WU wind and solar values while constructing daily history. Stations without a solar sensor therefore returned error 10 for both Zimmerman and ETo, even though Zimmerman does not use those fields and older versions treated missing ETo inputs as zero.
Validation