feat(badges): augment validateBadge payload for attendee-networking connect resolve#571
Conversation
…onnect resolve
Extend GET /summits/{id}/badge/{badge}/validate so attendee-networking-api can
resolve a scanned badge to a connection identity (SDS D26 / ftn-docsnsklz #40):
- add ticket.owner.id (keys the member-less pre-account request, D27)
- expand the nested ticket.owner.member {id, first_name, last_name, pic}
(member.id is the D15 identity; member is absent for member-less attendees)
No auth change is needed: the auth.user middleware passes service tokens
through (required-groups gate only user tokens), so a client-credentials
service account holding the read scope already reaches the route.
Tests (OAuth2SummitApiTest): the member case asserts the expanded member
object; the member-less case (D27) asserts the member object is absent while
attendee id + email are present. InsertSummitTestData gains a member-less
attendee with a badge to cover it.
|
📘 OpenAPI / Swagger preview ➡️ https://OpenStackweb.github.io/summit-api/openapi/pr-571/ This page is automatically updated on each push to this PR. |
|
Warning Review limit reached
Next review available in: 52 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
smarcet
force-pushed
the
feat/augment-validate-badge
branch
from
7c93012 to
8af8b08
Compare
|
📘 OpenAPI / Swagger preview ➡️ https://OpenStackweb.github.io/summit-api/openapi/pr-571/ This page is automatically updated on each push to this PR. |
…cketForEditionByOrderHash The memberless-attendee fixture added in fc2025a (#571) created the first single-ticket order in InsertSummitTestData, waking the previously-skipped testGetTicketForEditionByOrderHash. That order was owned by defaultMember while its only ticket belonged to memberless@test.com, so SummitOrder::isSingleOrder() failed and getMyTicketByOrderHash returned 412. - own the fixture order via setOwnerEmail(memberless@test.com) plus explicit first/last name (required by SummitOrder::generateHash) - fix the test's expected status code: the endpoint responds created() (201), not 200; the assertion had never executed before because the test always skipped for lack of single-ticket orders
Owner schema was stale since fc2025a (#571) added ticket.owner.id, ticket.owner.email, ticket.owner.company, and the nested ticket.owner.member object to the actual validateBadge response, but the OpenAPI schema was never updated to match. - Owner: add id, email, company; add member (ref OwnerMember, absent for member-less attendees per D27) - New OwnerMember schema: id, first_name, last_name, pic — the exact subset the controller's field whitelist returns (not the full Member schema) Verified by regenerating storage/api-docs/api-docs.json inside the running app container and diffing against the controller's serializer field whitelist.
2 participants
https://app.clickup.com/t/9014802374/86bauc5hf
Extend GET /summits/{id}/badge/{badge}/validate so attendee-networking-api can resolve a scanned badge to a connection identity (SDS D26 / ftn-docsnsklz #40):
No auth change is needed: the auth.user middleware passes service tokens through (required-groups gate only user tokens), so a client-credentials service account holding the read scope already reaches the route.
Tests (OAuth2SummitApiTest): the member case asserts the expanded member object; the member-less case (D27) asserts the member object is absent while attendee id + email are present. InsertSummitTestData gains a member-less attendee with a badge to cover it.