Fix mismatched optional/static view aliases

[jcmosc]

For static view aliases, i.e. where AnySource.valueIsNil is itself nil (i.e. not nillable), the view type is just Source.
For optional view aliases, i.e. where AnySource.valueIsNil can be evaluated, the view type is Optional<Source>.

[augmentcode]

🤖 Augment PR Summary

Summary: Fixes how view aliases choose their debuggable view type based on whether the underlying source is nillable.

Changes:

• Uses Source for static aliases (valueIsNil == nil) and Optional<Source> for optional aliases across view, view-list, and view-list-count paths.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 1 suggestion posted.

Comment augment review to trigger a new review at any time.

[augmentcode]

Sources/OpenSwiftUI/View/Configuration/ViewAlias.swift:233: In the source.valueIsNil != nil branch, using Optional<Source> here can become a double-optional (V??) since AnySource.init(Attribute<V?>) sets formula = SourceFormula<V?>, which may cause a mismatched Attribute(identifier:) cast at runtime. Can you confirm the intended Source generic in this branch is the non-optional wrapped view type (not already Optional<Wrapped>)?

Severity: medium

Other Locations

• Sources/OpenSwiftUI/View/Configuration/ViewAlias.swift:254
• Sources/OpenSwiftUI/View/Configuration/ViewAlias.swift:268

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}