Fix Folia inventory close thread access#292
Merged
ptthanh02 merged 1 commit intoJul 17, 2026
Merged
Conversation
Alexteens24
force-pushed
the
agent/fix-folia-inventory-close
branch
from
July 16, 2026 23:27
3032375 to
ff1a26b
Compare
Alexteens24
marked this pull request as ready for review
July 16, 2026 23:28
Alexteens24
changed the title
Alexteens24
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
InventoryCloseEvent.StoragePageHolderto close handling instead of scheduling another entity task.Why
On Folia/Canvas, the deferred entity task could execute in the player's current region while
Inventory#getHolder()accessed a block-backed inventory owned by another region. Canvas rejected that cross-region world read withThread failed main thread check: Cannot read world asynchronously.Impact
Closing inventories no longer causes SmartSpawner to perform an invalid cross-region holder lookup, while dirty storage state continues to be marked for persistence.
Validation
./gradlew :core:compileJavagit diff --check