Skip to content

fix: emit destination as a string (OVOS-MSG-1 §3.3) - #189

Merged
JarbasAl merged 1 commit into
devfrom
fix/msg1-33-destination-string
Sep 17, 2026
Merged

JarbasAl merged 1 commit into
devfrom
fix/msg1-33-destination-string

Conversation

@openvoiceos-bot

Copy link
Copy Markdown
Contributor

Disclosure: an AI agent (Claude Opus 5) wrote this change. A human reviews it before merge.

Change

base/files/ovos-hc.py: the readiness request sends source as "docker" and destination as the service name, not one-item lists. §3.2 gives source no list form either.

The clause

OpenVoiceOS/architecture origin/dev f23dbec, msg-1.md §3.3:

destination — string — opaque identifier of the intended consumer.
Absence means broadcast — every subscriber to the topic is an intended
consumer. A Message addresses one consumer or all of them; there is no
multi-address form. A producer that wants several specific consumers emits
one Message per consumer, or broadcasts.

Compatibility

Every consumer of destination in the fleet was read at its ref. None of them indexes the field or compares it to a list.

A string arrives safely on old and new consumers. The spec-tools reply() swap takes a string as it is. The list branch in ovos-spec-tools stays until all producers are migrated.

Record: knowledge/wiki/audits/spec-adoption/t2279-msg1-33-array-destination-producers.md. The first migration was JarbasHiveMind/HiveMind-core#357.

Tests

No test suite. The script was not run against a bus. Base: 988a79a.

No live bus run.

🤖 Generated with Claude Code

§3.3 gives destination one form, a string, with no multi-address form.
Every value here was a one-item list.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@goldyfruit goldyfruit self-assigned this Sep 17, 2026
@JarbasAl
JarbasAl marked this pull request as ready for review September 17, 2026 21:12
@JarbasAl
JarbasAl merged commit 65ccb08 into dev Sep 17, 2026
9 checks passed
@JarbasAl
JarbasAl deleted the fix/msg1-33-destination-string branch September 17, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants