fix: emit destination as a string (OVOS-MSG-1 §3.3) - #189
Merged
Merged
Conversation
§3.3 gives destination one form, a string, with no multi-address form. Every value here was a one-item list. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclosure: an AI agent (Claude Opus 5) wrote this change. A human reviews it before merge.
Change
base/files/ovos-hc.py: the readiness request sendssourceas"docker"anddestinationas the service name, not one-item lists. §3.2 givessourceno list form either.The clause
OpenVoiceOS/architectureorigin/devf23dbec,msg-1.md§3.3:Compatibility
Every consumer of
destinationin the fleet was read at its ref. None of them indexes the field or compares it to a list.A string arrives safely on old and new consumers. The spec-tools
reply()swap takes a string as it is. The list branch inovos-spec-toolsstays until all producers are migrated.Record:
knowledge/wiki/audits/spec-adoption/t2279-msg1-33-array-destination-producers.md. The first migration was JarbasHiveMind/HiveMind-core#357.Tests
No test suite. The script was not run against a bus. Base:
988a79a.No live bus run.
🤖 Generated with Claude Code