Repository navigation
fix: install the onnx-asr plugin on alpha only - #201
Conversation
On testing the install does not fail, it succeeds by raising ovos-plugin-manager to 2.2.0, past the <2.0.0 that the channel's ovos-vad-plugin-noise 0.1.2 and ovos-vad-plugin-silero 0.0.5 accept. The arm64 listener then failed its pip check and testing was not published (run 37535956317). ovos-installer only configures local speech on alpha, so the other channels do not need the plugin at all. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe listener Dockerfile now attempts to install ONNX ASR packages only when ChangesONNX ASR installation
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The change limits the explicit ONNX ASR install to alpha. No actionable regression from this change is established; the reported image build remains unchecked. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change narrows automatic package installation without expanding listener privileges or changing model-directory ownership. No introduced security concern was identified. Compatibility across channels remains uncertain because resolved dependencies and completed image-build results were not available. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Why
#200 installs
ovos-stt-plugin-onnx-asrin the listener image, with a fallback for channels where it doesn't resolve. On testing it does resolve, by raising ovos-plugin-manager to 2.2.0. That is past the<2.0.0the testing channel'sovos-vad-plugin-noise0.1.2 andovos-vad-plugin-silero0.0.5 accept. The arm64 testing listener then failed itspip checksmoke test and was not published (run 37535956317, job "testing / Create channel manifests"). Alpha passed on both architectures and is published.Change
The install now only runs when
OVOS_CHANNELisalpha, which the base image sets as an environment variable. ovos-installer only configures local speech on alpha (OpenVoiceOS/ovos-installer#648), so the other channels never need the plugin. The model directory is still created everywhere, which keeps theovos_stt_modelsvolume owned byovoswhatever the channel.Test plan
bash -non the listener'sRUNinstruction, with the comment lines dropped and the continuations joined as Docker does.🤖 Generated with Claude Code
Summary by CodeRabbit
listener.list.