Skip to content

feat: change figure diff 编辑功能 - #657

Merged
MakinoharaShoko merged 2 commits into
devfrom
change-figure-diff
Sep 23, 2026
Merged

MakinoharaShoko merged 2 commits into
devfrom
change-figure-diff

Conversation

@MakinoharaShoko

Copy link
Copy Markdown
Member

配合 OpenWebGAL/WebGAL#1034 实现

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 013e9da039

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

"vscode-ws-jsonrpc-webgal": "0.2.1",
"webgal-engine": "4.6.4",
"webgal-parser": "4.6.3",
"webgal-parser": "4.6.5-beta.1",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Upgrade the bundled engine with the parser

When users preview or export a game with the bundled/default runtime, the new changeFigureDiff statements cannot execute: this upgrades only webgal-parser, while packages/terre2/package.json still pins webgal-engine to 4.6.4 and the checked-in WebGAL_Template/webgal-engine.json likewise identifies the runtime as 4.6.4. Since this command is introduced by the newer engine work referenced by the commit, the bundled engine must be upgraded alongside the parser before exposing the editor action.

Useful? React with 👍 / 👎.

Comment on lines +68 to +69
msgid "changeFigureDiff:选择立绘文件;"
msgstr ""

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Translate the new command strings for every locale

In English, Japanese, and Korean locales, all three new messages have empty msgstr values. Because the Lingui configuration falls missing translations back to the Chinese source locale, users of those interfaces will see Chinese for the new button, description, and inserted placeholder instead of their selected language; populate these entries in each non-source catalog.

Useful? React with 👍 / 👎.

@MakinoharaShoko
MakinoharaShoko merged commit b9261d4 into dev Sep 23, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant