Repository navigation
feat: change figure diff 编辑功能 - #657
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 013e9da039
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "vscode-ws-jsonrpc-webgal": "0.2.1", | ||
| "webgal-engine": "4.6.4", | ||
| "webgal-parser": "4.6.3", | ||
| "webgal-parser": "4.6.5-beta.1", |
There was a problem hiding this comment.
Upgrade the bundled engine with the parser
When users preview or export a game with the bundled/default runtime, the new changeFigureDiff statements cannot execute: this upgrades only webgal-parser, while packages/terre2/package.json still pins webgal-engine to 4.6.4 and the checked-in WebGAL_Template/webgal-engine.json likewise identifies the runtime as 4.6.4. Since this command is introduced by the newer engine work referenced by the commit, the bundled engine must be upgraded alongside the parser before exposing the editor action.
Useful? React with 👍 / 👎.
| msgid "changeFigureDiff:选择立绘文件;" | ||
| msgstr "" |
There was a problem hiding this comment.
Translate the new command strings for every locale
In English, Japanese, and Korean locales, all three new messages have empty msgstr values. Because the Lingui configuration falls missing translations back to the Chinese source locale, users of those interfaces will see Chinese for the new button, description, and inserted placeholder instead of their selected language; populate these entries in each non-source catalog.
Useful? React with 👍 / 👎.
配合 OpenWebGAL/WebGAL#1034 实现