flags: export persistFlagsFromURL for bundle-specific flag keys - #326
Open
etiennelatendresse-optable wants to merge 1 commit into
Open
flags: export persistFlagsFromURL for bundle-specific flag keys#326etiennelatendresse-optable wants to merge 1 commit into
etiennelatendresse-optable wants to merge 1 commit into
Conversation
etiennelatendresse-optable
force-pushed
the
migrate-flag-from-url-from-solution
branch
from
August 24, 2026 20:10
9247151 to
1404a5b
Compare
mosherBT
reviewed
Aug 25, 2026
etiennelatendresse-optable
force-pushed
the
migrate-flag-from-url-from-solution
branch
from
August 25, 2026 17:03
1404a5b to
e2ba4c1
Compare
etiennelatendresse-optable
changed the title
etiennelatendresse-optable
force-pushed
the
migrate-flag-from-url-from-solution
branch
from
August 25, 2026 17:09
e2ba4c1 to
2602e27
Compare
etiennelatendresse-optable
force-pushed
the
migrate-flag-from-url-from-solution
branch
from
August 25, 2026 17:13
2602e27 to
0f4619b
Compare
mosherBT
reviewed
Aug 26, 2026
| * export is for wrapper bundles with flags of their own that don't belong in | ||
| * the shared key list. Those keys never enter the typed Flags object; the | ||
| * bundle reads them back from sessionStorage and must treat "0" and empty | ||
| * values as disabled, like flagEnabled() does. |
Contributor
There was a problem hiding this comment.
Remove this comment IMO. Just describe the function
mosherBT
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
setOptableFlagsFromURLQueryallows reading debug flag from the url and persist them in the sessionStorage for the rest of the tab session.What Changed
setOptableFlagsFromURLQueryHow to Test
Notes