ROU-12978: Rebrand Storybook with custom docs pages and manager chrome - #1222
Merged
Conversation
Replace Introduction/inline MDX with React doc pages (Welcome, Getting Started, Component Library, CSS Architecture, Theme Editor) and an interactive CSS API Reference fed by the generated manifest, while aligning manager sidebar, appearance sync, and sticky doc navigation with the new layout. Co-authored-by: Cursor <cursoragent@cursor.com>
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try the Wiz Code extension for VS Code, JetBrains, or Visual Studio. Pull Request Developer GuidanceQuestions? See the Wiz FAQ. Please contact the Security Office if you encounter issues with Wiz pull request scanning. |
Without a committed lockfile, npm i on Chromatic resolves ^10.4.1 to 10.5.10, which is not yet available on the internal Azure Artifacts feed. Co-authored-by: Cursor <cursoragent@cursor.com>
Integrate design tokens 2.0, platform CSS mock, and root-layer updates while keeping branded Storybook docs pages and pinned Storybook 10.5.9. Co-authored-by: Cursor <cursoragent@cursor.com>
Improve CSS API Reference layout, Theme Editor controls, Getting Started illustrations, sidebar spacing, and dark-mode fixes across docs pages. Co-authored-by: Cursor <cursoragent@cursor.com>
…bar. Introduce generated token reference pages (colours, type, spacing, borders, shape, elevation, transitions), group them with CSS Architecture, API Reference, and Theme Editor under Design system, and align docs chrome, dark mode, and cross-page links. Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve generate-css-api-reference conflict by keeping the React-only generator (esc helper removed with legacy markdown output). Co-authored-by: Cursor <cursoragent@cursor.com>
Resolved stories/CssApiReference.mdx by keeping the redesigned page wrapper and regenerating the CSS API manifest (npm run docs:css-api) so it includes the new --osui-* properties from ROU-12714. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The Theme Editor memos read an external override store and used 'void changeTick' to mark the invalidation tick as used. stories/ is not covered by the react-hooks lint, so the deps arrays alone suffice. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
SonarCloud flagged four functions over the 15 threshold: - parseSpacingUtilities (32) -> extracted per-kind class matchers + a shared look-ahead scale finder - generateColors classifier (47) -> split into per-category collectors with shared entry builders and an early-return dispatch - parseTypographyMaps (23) -> extracted map-prop parsing, part resolution, and variant naming helpers - extract in generate-css-api-reference (26) -> extracted interpolation scanner and --osui-* declaration parser Verified with eslint-plugin-sonarjs (all now <= 15) and by regenerating both outputs: token-data and css-api manifest are byte-identical. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
🖼️ Storybook: Chromatic UI tests result: ✅ Passed
|
Contributor
|
Sonarcloud repeated code warning is a false-positive |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduction.mdxand inline MDX docs with branded React pages: Welcome, Getting Started, Component Library, CSS Architecture, and Theme Editor (MDX wrappers + dedicated page components).CssApiReferencePage) fed bynpm run docs:css-api, which now generatescss-api-manifest.tsplus a thinCssApiReference.mdxwrapper (keeps ROU-12714 script-driven source of truth, no duplicatedocs/css-api-reference.md).Test plan
npm run storybookand verify Welcome, Getting Started, Component Library, CSS Architecture, CSS API Reference, and Theme Editor pages render in light and dark appearance.npm run docs:css-apiand confirmcss-api-manifest.ts+CssApiReference.mdxregenerate without manual edits.Made with Cursor