Repository navigation
Rebuild the press kit archive from scratch - #130
Merged
Merged
Conversation
`zip -r` adds to an archive that already exists rather than replacing it, and `Output/` survives a local build. A file removed from `presskit/` therefore stayed in `presskit.zip` indefinitely, so a locally built kit could ship assets that no longer exist in the repository. CI never showed this because its output folder starts empty, which is exactly what made the local archive able to drift from the deployed one unnoticed.
It is git-ignored, so a fresh CI checkout never has one and the deployed archive was always clean. A local build zips whatever the folder holds, which is the same way the archive could drift from what ships.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zip -radds to an archive that already exists rather than replacing it, andOutput/survives a local build — so a file removed frompresskit/stayed inpresskit.zipindefinitely.buildPressKitArchive()deletespresskit.zipbefore runningzip, so the archive is always exactly the contents ofpresskit/.DS_Storeis excluded, for the same reason: it is git-ignored, so it only ever reaches the archive from a local buildVerified by adding a file to
presskit/, building, deleting it, and building again — the entry is gone from the archive, where before it survived.